From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-dev+bounces-66493-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id DBBC213877A for <garchives@archives.gentoo.org>; Fri, 4 Jul 2014 13:14:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1EA60E0822; Fri, 4 Jul 2014 13:14:29 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3A2D4E07D7 for <gentoo-dev@lists.gentoo.org>; Fri, 4 Jul 2014 13:14:28 +0000 (UTC) Received: from pomiot.lan (77-254-166-236.adsl.inetia.pl [77.254.166.236]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 66B2233FCE8; Fri, 4 Jul 2014 13:14:26 +0000 (UTC) Date: Fri, 4 Jul 2014 15:14:09 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= <mgorny@gentoo.org> To: Ulrich Mueller <ulm@gentoo.org> Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Standardise the variable for including eclasses only once Message-ID: <20140704151409.17c5d26d@pomiot.lan> In-Reply-To: <21430.29481.773070.678302@a1i15.kph.uni-mainz.de> References: <21430.29481.773070.678302@a1i15.kph.uni-mainz.de> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/r1paLGt1YFLDzn6U+lO/Ipy"; protocol="application/pgp-signature" X-Archives-Salt: bc49d101-3539-429b-b393-0c5638cc5784 X-Archives-Hash: 8c374cdc44291e0a0fe47101c717e01c --Sig_/r1paLGt1YFLDzn6U+lO/Ipy Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-07-04, o godz. 11:26:01 Ulrich Mueller <ulm@gentoo.org> napisa=B3(a): > Since names like _USER or _PAM look a little dangerous, I suggest > _<eclassname>_ECLASS for the variable's name. >=20 > I have no strong preference for the variable's value. Is testing for > a non-empty value sufficient? Then we should assign something simple > (like "1"). If not, any string that is sufficiently random (like the > one used in eutils) should be good. I'd rather go for simple value and simple test. Exact tests with weird names are more prone to mistakes, and this is not something you usually test. While at it, I would also like to ask all eclasses to keep EXPORT_FUNCTIONS *outside* the ifs to keep the exports consistent with inherits. Otherwise, indirect inheritance influences effectively exported phase functions and changes in 'inherit' order may affect exported functions seemingly randomly. --=20 Best regards, Micha=B3 G=F3rny --Sig_/r1paLGt1YFLDzn6U+lO/Ipy Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJTtqilXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOkN8QAMQpeCsGbvEqjEZNycmF9VV5 rK9Pl6NLrKHUol0Ymr8VFYcPA/uHek5dUVBYfrydl3p5NoPJncTdTfkHgBTxL25N gC4NdVD9OEvobBVoAuIQdTD6V5RLoxS/RvL35+ilG25EDHInJS8IkeauAQjpKFNh ffdbIrvPRDep+lybFwS+QLIcv8VXljCbfDNpA5WH3vX4k4+zQEqwJG3Wyp+ygckQ 0b5y/x32LEEcyhGEs9o15Dbis5KzBEa7ekXviBMW3qhUvRlKIjPhrdBGtx+NxSg1 W39tBBLdPqEqSqA+lQF/SMXy+LrUz2SK94yUi8z9xPqrU5z7yEM53dbWhP94c/wb xufi/a4YBgW45gMIgAo9pttYw2c9ciress2DtY2fLMNVpjEkTBujXrd4QjTM5Pwd 1dAAP25FC8LnKglWjtVTJju7PMLTEIT3PcOD4nCYVj/YeDcfMIwmkJ0C5bQ8M3DX q0QvAoq8peftPZeSbJ1In3mwvd43u7tkMbmfPad1MDncHcYyMkkx/47KncYKwNNr j5Gg5yF9+54SZv3TQfVOxrUMW48AdYMz/NKytM/X5rum34AioIN/O0u2fc+nGGXz VfhrjbKJXoEpOSxzB8eHlP+oteGu4M6Hb4tn19Ta8P9cLT9X4fbVWsYFKXKXKZGi /EvkyohEPS32C019ytRU =oOY6 -----END PGP SIGNATURE----- --Sig_/r1paLGt1YFLDzn6U+lO/Ipy--