From: Jeroen Roovers <jer@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch
Date: Mon, 23 Jun 2014 04:01:30 +0200 [thread overview]
Message-ID: <20140623040130.0fe6e30f@marga.jer-c2.orkz.net> (raw)
In-Reply-To: <53A70D99.1040503@gentoo.org>
On Sun, 22 Jun 2014 20:08:41 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:
> LIBS = `$(PKG_CONFIG) gtk+-2.0 --libs` -lm -X11
No, it should be
LIBS = $(shell $(PKG_CONFIG) ...)
or PKG_CONFIG will be called every time LIBS is evaluated.
And while you're at it, why not call PKG_CONFIG on x11, too?
LIBS = $(shell $(PKG_CONFIG) --libs gtk+-2.0 x11) -lm
jer
next prev parent reply other threads:[~2014-06-23 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140622162511.10F352004F@flycatcher.gentoo.org>
2014-06-22 17:08 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch Samuli Suominen
2014-06-23 2:01 ` Jeroen Roovers [this message]
2014-06-23 4:18 ` Samuli Suominen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623040130.0fe6e30f@marga.jer-c2.orkz.net \
--to=jer@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox