From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3E19E138A1F for ; Sat, 12 Apr 2014 00:10:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B57E8E0A49; Sat, 12 Apr 2014 00:10:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C9C11E0A40 for ; Sat, 12 Apr 2014 00:10:29 +0000 (UTC) Received: by smtp.gentoo.org (Postfix, from userid 2274) id EA21E33FE32; Sat, 12 Apr 2014 00:10:28 +0000 (UTC) Date: Fri, 11 Apr 2014 17:10:27 -0700 From: Tim Harder To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] fix java-utils-2 eclass to only use DESTTREE during src_install Message-ID: <20140412001027.GA11358@basil.av1.ca.us.gaikai.int> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20140401223156.GA22353@basil.av1.ca.us.gaikai.int> <20140411180211.0ab57edb@sera-20.lan> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20140411180211.0ab57edb@sera-20.lan> User-Agent: Mutt/1.5.23 (2014-03-12) X-Archives-Salt: 2e993325-b850-47ab-83bc-c202efbad472 X-Archives-Hash: 3066c1b2818405b2ce146de0c3ec76f1 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 2014-04-11 09:02, Ralph Sennhauser wrote: > java-utils-2 does it like that since before PMS, since around the time > Portage gained support for EAPIs. PMS leaves it open whether using > DESTREE in pkg_setup is allowed or not. Neither Portage, Paludis nor > earlier version of Pkgcore did mind this use. Well, one could argue > that using DESTREE in pkg_setup is allowed. Pkgcore explicitly worked around it for a long time (since 0.2.12-ish) specifically noting it was for this case until I dropped it recently since keeping targeted hacks around for things like this isn't great for maintainability. > I would welcome PMS clearly defining the scope of DESTREE and the most > logical choice of course would be src_install only where it is > currently explicitly required. Yep, as Ulrich noted (and I noted in the 2nd paragraph of my first message) PMS already defines the scope of DESTTREE to be src_install only. > If we fix java-utils-2 we should fix PMS as well. After all, > java-utils-2 is a prime suspect for the different handling of > DESTREE and for instance INSDESTREE in PMS. This asymmetry is why I > didn't touch java-utils-2 when I looked into exactly this usage of > DESTREE 2+ years ago. Just to note, I already committed the fix a few days ago after discussing it a bit on the java herd IRC channel. Really it would be great if someone was interested in reworking most of the java eclasses since they've been showing their age for a while now. Thanks, Tim --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJTSIRzAAoJEEqz6FtPBkyjJsEH/263Lu/ajJvTB6gbC032bPlJ PgTB9Mf1Ysae4XS7EwPRtY9+4mmZDtCyw4lD9Pb0GkNCuNfm5Ip9W5Fsm469/h51 vtCQ5fJGFJ49WVsgCB3yyvb0U/vsTvh8PTHQ00oP3PsU0UOCWBsQBvNwntJSNFvW zDutnqKe8Cy13xGtmsG5FGwo8e9/gyJRaEnD3ff0+D1qkhJufrb8bbxzaG9crWWh 1W8kQHwuiigICy8LwesyeLA74uDqT2Fa+pB+6beriOz6uC2okcluKPPkyCeim/1/ 9xxePxuX72ySx0iyktPyJwW3v+ovbQ3ba3nzr4Olz828c21lI2yOIlOETNCIs6c= =d8pE -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--