From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8EA491387FD for ; Sun, 6 Apr 2014 23:30:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 39986E0AB8; Sun, 6 Apr 2014 23:30:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 354D9E0A60 for ; Sun, 6 Apr 2014 23:30:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 1ACC433F8BA for ; Sun, 6 Apr 2014 23:30:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -0.594 X-Spam-Level: X-Spam-Status: No, score=-0.594 tagged_above=-999 required=5.5 tests=[RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.592, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=no Received: from smtp.gentoo.org ([IPv6:::ffff:127.0.0.1]) by localhost (smtp.gentoo.org [IPv6:::ffff:127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8l7IXJBDwxeC for ; Sun, 6 Apr 2014 23:30:09 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id ACADA33FD57 for ; Sun, 6 Apr 2014 23:30:09 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WWwVn-00013d-TB for gentoo-dev@gentoo.org; Mon, 07 Apr 2014 01:30:03 +0200 Received: from 71-17-69-121.yktn.hsdb.sasknet.sk.ca ([71.17.69.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Apr 2014 01:30:03 +0200 Received: from rhill by 71-17-69-121.yktn.hsdb.sasknet.sk.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Apr 2014 01:30:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: [PATCH] waf-utils.eclass: respect CFLAGS in linking command Date: Sun, 6 Apr 2014 17:12:21 -0600 Organization: Gentoo Message-ID: <20140406171221.1f82202f@caribou.gateway.pace.com> References: <5341769E.6040809@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/FS_AZQ4vY.MHPd4jP4G76Cx"; protocol="application/pgp-signature" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 71-17-69-121.yktn.hsdb.sasknet.sk.ca X-Newsreader: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-pc-linux-gnu) X-Archives-Salt: 7e00dc36-cd76-409a-b0ce-00ab235133c6 X-Archives-Hash: a77a8f473080b703dda0517ffb74ee13 --Sig_/FS_AZQ4vY.MHPd4jP4G76Cx Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 06 Apr 2014 15:45:34 +0000 hasufell wrote: > respect CFLAGS in linking command > https://bugs.gentoo.org/show_bug.cgi?id=3D506956 >=20 > --- eclass/waf-utils.eclass > +++ eclass/waf-utils.eclass > @@ -56,18 +56,18 @@ > [[ -z ${NO_WAF_LIBDIR} ]] && > libdir=3D"--libdir=3D${EPREFIX}/usr/$(get_libdir)"=20 > tc-export AR CC CPP CXX RANLIB > - echo "CCFLAGS=3D\"${CFLAGS}\" LINKFLAGS=3D\"${LDFLAGS}\" > \"${WAF_BINARY}\" --prefix=3D${EPREFIX}/usr ${libdir} $@ configure" > + echo "CCFLAGS=3D\"${CFLAGS}\" LINKFLAGS=3D\"${CFLAGS} ${LDFLAGS}\" > \"${WAF_BINARY}\" --prefix=3D${EPREFIX}/usr ${libdir} $@ configure"=20 > # This condition is required because waf takes even whitespace as > function # calls, awesome isn't it? > if [[ -z ${NO_WAF_LIBDIR} ]]; then > - CCFLAGS=3D"${CFLAGS}" LINKFLAGS=3D"${LDFLAGS}" "${WAF_BINARY}" \ > + CCFLAGS=3D"${CFLAGS}" LINKFLAGS=3D"${CFLAGS} ${LDFLAGS}" > "${WAF_BINARY}" \ "--prefix=3D${EPREFIX}/usr" \ > "${libdir}" \ > "$@" \ > configure || die "configure failed" > else > - CCFLAGS=3D"${CFLAGS}" LINKFLAGS=3D"${LDFLAGS}" "${WAF_BINARY}" \ > + CCFLAGS=3D"${CFLAGS}" LINKFLAGS=3D"${CFLAGS} ${LDFLAGS}" > "${WAF_BINARY}" \ "--prefix=3D${EPREFIX}/usr" \ > "$@" \ > configure || die "configure failed" Good. --=20 Ryan Hill psn: dirtyepic_sk gcc-porting/toolchain/wxwidgets @ gentoo.org 47C3 6D62 4864 0E49 8E9E 7F92 ED38 BD49 957A 8463 --Sig_/FS_AZQ4vY.MHPd4jP4G76Cx Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCgAGBQJTQd9eAAoJEO04vUmVeoRj1lAH/RdoAOJs1JBGkfWZW+9zDOSz A9LQDNQJTncHwAaxL8P+UjkGcgLQj0t/DwJrXKeHi8biU63NRQWehd5D6/qLv7za mJ4F51cfYUQJiX7G/Dm62jaf1w0zgO97XgV0QA9bt0AQFY/02nhQQW+QHQEci52y nSsio7s1ELxNpCxrnvtbCe5OKAHrC501l0DNuEdqeVhESlpdXElh+CjHn+cEAUG/ p4CJy4wjip7YsWd/vs5WufBo8F1AR0QtVwogHLl+XypKZSJuqqqN5BFs+aR53gNR yEzCEWMYC7eij1O+gK7yKmi9JCxdp0WR29bNC93bZ7cNX+WAFcXcg9GtNrcbSUc= =dqNr -----END PGP SIGNATURE----- --Sig_/FS_AZQ4vY.MHPd4jP4G76Cx--