[gentoo-dev] [PATCH] gnome2-utils.eclass: Fix SELinux labeling issue in gnome2_gdk_pixbuf_update()

[gentoo-dev] [PATCH] gnome2-utils.eclass: Fix SELinux labeling issue in gnome2_gdk_pixbuf_update()

[Luis Ressel]

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

The internals of gnome2-utils.eclass' gnome2_gdk_pixbuf_update(), which
is responsable for updating x11-libs/gdk-pixbuf's loaders.cache,
unfortunately cause problems with SELinux, as the mentioned file
doesn't get a correct context and is therefore inaccessible by
applications.

The trivial patch which I've proposed on b.g.o (#499636) has already been
acknowledged by the SELinux and GNOME herds, however the latter asked
me to send a mail to this ML as well. So, does anyone have objections
about this change?


--- gnome2-utils.eclass	2014-01-28 23:14:31.419135392 +0100
+++ gnome2-utils.eclass	2014-01-28 23:17:06.569269202 +0100
@@ -436,7 +436,8 @@ 
 	local tmp_file=$(mktemp -t tmp.XXXXXXXXXX_gdkpixbuf)
 	${updater} 1> "${tmp_file}" &&
 	chmod 0644 "${tmp_file}" &&
-	mv -f "${tmp_file}" "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache"
+	cp -f "${tmp_file}" "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache" &&
+	rm "${tmp_file}" # don't replace this with mv, required for SELinux support
 	eend $?
 }
 


--
Luis Ressel <aranea@aixah.de>
GPG fpr: F08D 2AF6 655E 25DE 52BC  E53D 08F5 7F90 3029 B5BD

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]