From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-62732-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 9F6311381F3
	for <garchives@archives.gentoo.org>; Sun,  8 Sep 2013 21:29:58 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 7CCADE09F5;
	Sun,  8 Sep 2013 21:29:51 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id B075DE09EB
	for <gentoo-dev@lists.gentoo.org>; Sun,  8 Sep 2013 21:29:50 +0000 (UTC)
Received: from portable (pc-8-198-44-190.cm.vtr.net [190.44.198.8])
	(using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: aballier)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 59CAE33DA6C
	for <gentoo-dev@lists.gentoo.org>; Sun,  8 Sep 2013 21:29:49 +0000 (UTC)
Date: Sun, 8 Sep 2013 23:29:43 +0200
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH systemd.eclass] Introduce
 systemd_install_serviced().
Message-ID: <20130908232943.5b8c2def@portable>
In-Reply-To: <20130908174628.277ebfaf@gentoo.org>
References: <1378638746-8626-1-git-send-email-mgorny@gentoo.org>
	<1378653294.997.1.camel@kanae>
	<20130908174628.277ebfaf@gentoo.org>
Organization: Gentoo
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 0666db9c-2ff6-4dfc-9fe4-1483225bf439
X-Archives-Hash: 09a23a6d26fb114f89125e064be42c1a

On Sun, 8 Sep 2013 17:46:28 +0200
Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org> wrote:
> > > suffix" +
> > > +	local INSDESTTREE
> >=20
> > I guess this is a leftover ?
>=20
> Nope. 'insinto' sets INSDESTTREE. Due to lack of proper scoping
> support in bash, we need to localize this variable to restore previous
> 'insinto' scope after leaving the function.

its much better to use a subshell like the other eclasses for that