public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH systemd.eclass] Introduce systemd_install_serviced().
Date: Sun, 8 Sep 2013 23:29:43 +0200	[thread overview]
Message-ID: <20130908232943.5b8c2def@portable> (raw)
In-Reply-To: <20130908174628.277ebfaf@gentoo.org>

On Sun, 8 Sep 2013 17:46:28 +0200
Michał Górny <mgorny@gentoo.org> wrote:
> > > suffix" +
> > > +	local INSDESTTREE
> > 
> > I guess this is a leftover ?
> 
> Nope. 'insinto' sets INSDESTTREE. Due to lack of proper scoping
> support in bash, we need to localize this variable to restore previous
> 'insinto' scope after leaving the function.

its much better to use a subshell like the other eclasses for that


  reply	other threads:[~2013-09-08 21:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-08 11:12 [gentoo-dev] [PATCH systemd.eclass] Introduce systemd_install_serviced() Michał Górny
2013-09-08 15:14 ` Gilles Dartiguelongue
2013-09-08 15:40   ` Pacho Ramos
2013-09-08 15:46   ` Michał Górny
2013-09-08 21:29     ` Alexis Ballier [this message]
2013-09-10 10:57 ` [gentoo-dev] " Steven J. Long
2013-09-10 16:36   ` Michał Górny
2013-09-10 17:28     ` Mike Gilbert
2013-09-12 11:48 ` [gentoo-dev] " Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130908232943.5b8c2def@portable \
    --to=aballier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox