From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: hattya@gentoo.org
Subject: Re: [gentoo-dev] [PATCH subversion.eclass] Export working copy information after the update.
Date: Sat, 27 Jul 2013 12:18:53 +0200 [thread overview]
Message-ID: <20130727121853.21778d1c@gentoo.org> (raw)
In-Reply-To: <1374605175-14648-1-git-send-email-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Dnia 2013-07-23, o godz. 20:46:15
Michał Górny <mgorny@gentoo.org> napisał(a):
> Currently, subversion.eclass exports working working copy information
> such as ESVN_WC_REVISION two times: once before running 'svn up',
> and the second time in pkg_preinst(). As a result, between those two
> calls ESVN_WC_REVISION lists the *previous* working copy revision rather
> than the current one.
>
> This behavior is not exploited by any ebuild. Instead, all ebuilds that
> use ESVN_WC_REVISION either hack it around, or actually use the wrong
> revision mistakenly.
>
> The patch fixes the eclass to export working copy information *after*
> the update is done. Redundant call to subversion_wc_info is removed from
> pkg_preinst() as no ebuild needs the re-export.
>
> Fixes: https://bugs.gentoo.org/show_bug.cgi?id=282486
Committed.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]
prev parent reply other threads:[~2013-07-27 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 18:46 [gentoo-dev] [PATCH subversion.eclass] Export working copy information after the update Michał Górny
2013-07-27 10:18 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130727121853.21778d1c@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=hattya@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox