From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A32761381F3 for ; Thu, 18 Jul 2013 07:13:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A1DE4E092C; Thu, 18 Jul 2013 07:12:58 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B50C3E077F for ; Thu, 18 Jul 2013 07:12:57 +0000 (UTC) Received: from localhost (178-37-165-168.adsl.inetia.pl [178.37.165.168]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 5893C33E7BA; Thu, 18 Jul 2013 07:12:50 +0000 (UTC) Date: Thu, 18 Jul 2013 09:12:55 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: jlec@gentoo.org Subject: Re: [gentoo-dev] RFC: fortran-2.eclass - Support for bin package system without compiler Message-ID: <20130718091255.594be68a@gentoo.org> In-Reply-To: <51E7942A.7070309@gentoo.org> References: <51E7942A.7070309@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/g7K+GIZxEy7sESUDjG/Pks5"; protocol="application/pgp-signature" X-Archives-Salt: 45fbf9b2-8337-49b0-bd29-02ad2be05422 X-Archives-Hash: 2ed7cff2a8c568bbf3b9183e9552a53c --Sig_/g7K+GIZxEy7sESUDjG/Pks5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2013-07-18, o godz. 09:07:22 Justin napisa=C5=82(a): > Index: fortran-2.eclass > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /var/cvsroot/gentoo-x86/eclass/fortran-2.eclass,v > retrieving revision 1.18 > diff -u -B -b -u -p -r1.18 fortran-2.eclass > --- fortran-2.eclass 18 Jul 2013 07:03:33 -0000 1.18 > +++ fortran-2.eclass 18 Jul 2013 07:06:41 -0000 > @@ -203,11 +203,11 @@ _fortran_test_function() { > fi > } >=20 > -# @FUNCTION: fortran-2_pkg_setup > +# @FUNCTION: _fortran-2_pkg_setup > +# @INTERNAL > # @DESCRIPTION: > -# Setup functionallity, > -# checks for a valid fortran compiler and optionally for its openmp > support. > -fortran-2_pkg_setup() { > +# _The_ fortran-2_pkg_setup() Looks like useful comment ;P. > +_fortran-2_pkg_setup() { > for _f_use in ${FORTRAN_NEEDED}; do > case ${_f_use} in > always) > @@ -229,6 +229,29 @@ fortran-2_pkg_setup() { > done > } >=20 > + > +# @FUNCTION: fortran-2_pkg_setup > +# @DESCRIPTION: > +# Setup functionallity, > +# checks for a valid fortran compiler and optionally for its openmp > support. > +fortran-2_pkg_setup() { > + if [[ ${EAPI:-0} -lt 4 ]]; then Someone else's going to tell you this, so I'll tell you it first hand: EAPI is not guaranteed to be a number and you shouldn't be using numerical comparison against it. Not that you support any non-numerical EAPI. But then some people who fork eclasses in overlays will have to patch it more to support their weird EAPIs. And I'm not pointing my finger at anyone in particular. > + eqawarn "The fortran-2.eclass is going to deprecate support for" > + eqawarn "EAPI < 4. Please migrate your package to a higher EAPI" > + eqawarn "or file a bug at https://bugs.gentoo.org" > + fi > + > + case ${EAPI:-0} in > + 0|1|2|3) > + _fortran-2_pkg_setup ;; > + 4|5) > + if [[ ${MERGE_TYPE} !=3D binary ]]; then > + _fortran-2_pkg_setup > + fi > + ;; > + esac > +} > + > case ${EAPI:-0} in > 0|1|2|3|4|5) EXPORT_FUNCTIONS pkg_setup ;; > *) die "EAPI=3D${EAPI} is not supported" ;; --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/g7K+GIZxEy7sESUDjG/Pks5 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQJ8BAEBCgBmBQJR55V3XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKAQgP/AtgJRpO/yTZmBkxKFNHQ763 xNAgkTxm0w8ioDKdgfldrijBaNkOmYZSo2iBUVgdTgGZWoaE7/doZTuGnLeEpSFu YOlPEFAn9g5WbILH3gV2uedhRWS1a4rs+3dzuOTSr1HTFH6dZCr2enVH6txyHWNu pkvuquiSt927gh29R0pxOhis4nPIJIFN8073mAY6q8GIRFdOo0GAIchv+6j/CnIU NFE/VQn3+QTgjPXZt1HTcZ2tOsv5UvdVZRpoHsoS6KUqmjPbJi8NfufgD+QC7n+o 2Ic8MDgs9Rok6mltoO2K5ZJi538fR39da/HUSF2X9xUTcHVufcZAs7VglEYNyac2 DSMAa/1jtt4YRljkx2FPKP8736Z3JSZZR62bLIGfn9gORs+M1N2ArfoQvtBAP9cL CA9VVlm4Hzplf8tmfWTJX283YrQo4GH+c0XCFjVaXl2/INbc5rw9/PObrViZ8pFB wwYkr6I/gdBYlDwneFiLXyOfsRDdQZKxeajeWsbWq0VlytnsJQsFhkd2tQNgZY4O 88oW/mBtUu4N/W9k5IZRJuIMPo4ZrmNQQ36ABRS5a3JcCJJdRE5uH51cTLK/tIsq ukwztxOCi7T9KZZYA4iE8cfU5wEZXEmePuJhXlmlGiQSC6lWVmKTMmq7UB9Lo67s WdzYMjYqq/ivpiCwPa51 =YhBi -----END PGP SIGNATURE----- --Sig_/g7K+GIZxEy7sESUDjG/Pks5--