Re: [gentoo-dev] cmake-utils.eclass and bug 475502

["Michał Górny" <mgorny@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Dnia 2013-07-17, o godz. 17:42:32
"Rick \"Zero_Chaos\" Farina" <zerochaos@gentoo.org> napisał(a):

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 07/17/2013 05:34 PM, hasufell wrote:
> > On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote:
> >> ...and that is why it isn't permitted to directly use an eclass
> >> that you don't inherit.  While I agree testing could (should) have
> >> been better, the fact that people ignore the rules for writing
> >> ebuilds shouldn't entirely fall on the KDE team.
> > 
> > 
> > It doesn't matter in the slightest whos fault it is or who should be
> > blamed.
> > 
> > It is about maintaining stability for the user. Especially when it
> > comes to stable ebuilds.
> > 
> > That means the methods for eclass changes must be more thoroughly.
> 
> I completely agree with you, the changes should have been tested better.
>  The ebuilds with these errors popping up ALSO should have been tested
> better.  Considering this is a QA violation, perhaps it is possible to
> add a check in repoman for using something from an eclass which you
> didn't inherit.  I doubt the slowdown would be horrible and clearly it
> would catch a huge number of QA violations.

Repoman has such check already. It pops up for specific functions
listed in repoman source code. This allows us to catch the common
mistakes while avoiding false positives.

Maybe it should always pop up for phase functions. I don't immediately
see a reason why an ebuild would use a phase function of an eclass it
doesn't inherit directly.

- -- 
Best regards,
Michał Górny
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQJ8BAEBCgBmBQJR55QGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC
QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKHMcQAIwiDjgyegvvuHl9dzSlRK9S
uTZH/kSBrIRppXIDWqC48Cj1LrRGVZoWIbHE9xd4qd0Hb37jva07JmTRW5/p/6aI
62a7Rfb9WZl0z75PZbk4id9idAPF1Gu35gAS1mEjncUlz/jC5pQlVB0kdF0F+feU
FIXfoXD7U4LZBIjCmD3fvf6GBaQN4M/i0ZKj56BnHzVUqMUkOzSSmMLc9M+TqQZR
dFG7GlgUrUz6G86XwXMY0OCu85lo8VVDE7bcDDK+Yh5RXr7ZQ7GozPQR25VJ8G2K
PIxIS4hIZ0+W+zuPqDs0skjWhcdpIlYGEV5p35GVzmiHqqyaDKd/WVuVM6e4xl+2
CrcWjy9OJnmyVOGmjtG3QJBlG6MIRbPpF1B2NYNLkk14Vnw/iDCRjkU28WzeyKlf
x9j6BCWLFP4g8StyW0e6f9aprg3/svD6XH84oPD3+8AfbBud5s7w4r+bL2UpDalU
PsdUmBLdEfMzQroZP9jYGGEtzyzLIAnO8WKmRn73Pi9Heg43TN7KdZJMqwDqu2ZM
Nzpm4xH0SK/iz6QlGMJ86hLkV2TdkU+KLUn0Bd8785hqw1ozdVZm0LhtygnluJij
pCrFnbomR7z9a8yvB1eLbnbbgd6Q8oKoVXM/h2ap0ncoz3tqaJ+9ccKryV4fOi3T
prdfHAfmIU1YJFYCvY6B
=i8Zv
-----END PGP SIGNATURE-----