From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1DE201381F3 for ; Thu, 11 Jul 2013 18:30:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 52E70E0AEF; Thu, 11 Jul 2013 18:30:02 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6D3EDE0AEB for ; Thu, 11 Jul 2013 18:30:01 +0000 (UTC) Received: from localhost (178-37-160-127.adsl.inetia.pl [178.37.160.127]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 6B4FB33E946; Thu, 11 Jul 2013 18:29:59 +0000 (UTC) Date: Thu, 11 Jul 2013 20:29:56 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: yac@gentoo.org Subject: Re: [gentoo-dev] New eclass - twisted-r1 Message-ID: <20130711202956.54b0a98d@gentoo.org> In-Reply-To: <20130711133401.70b795b9@gentoo.org> References: <20130710144959.49c071f4@gentoo.org> <20130710222550.0b97aea5@gentoo.org> <20130710234011.34a72516@gentoo.org> <20130711085547.179e24d2@gentoo.org> <20130711133401.70b795b9@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/2_V6zKsFhBxXIE5NPo.xmez"; protocol="application/pgp-signature" X-Archives-Salt: 32478443-6bb8-46ae-867c-8df387db9256 X-Archives-Hash: 5daa726216946e1f95b9e7cedbd13edb --Sig_/2_V6zKsFhBxXIE5NPo.xmez Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2013-07-11, o godz. 13:34:01 yac napisa=C5=82(a): > On Thu, 11 Jul 2013 08:55:47 +0200 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Dnia 2013-07-10, o godz. 23:40:11 > > yac napisa=C5=82(a): > >=20 > > > On Wed, 10 Jul 2013 22:25:50 +0200 > > > Micha=C5=82 G=C3=B3rny wrote: > > >=20 > > > > First of all: please wrap lines at 72 or 80 chars (even if the > > > > original eclass didn't do that). > > > >=20 > > > > > if [[ "${CATEGORY}/${PN}" =3D=3D "dev-python/twisted"* ]]; then > > > >=20 > > > > I know you're not responsible for this but it seems wrong to have > > > > two different behaviors depending on PN. Is this used somewhere > > > > actually? > > > >=20 > > > > > MY_PV=3D"${MY_PV:-${PV}}" > > > > > MY_P=3D"Twisted${MY_PACKAGE}-${MY_PV}" > > > > >=20 > > > > > HOMEPAGE=3D"http://www.twistedmatrix.com/" > > > > > #SRC_URI=3D"http://tmrc.mit.edu/mirror/twisted/${MY_PACKAGE}/$(g= et_version_component_range > > > > > 1-2 ${MY_PV})/${MY_P}.tar.bz2" > > > > > SRC_URI=3D"http://twistedmatrix.com/Releases/${MY_PACKAGE}/$(get_= version_component_range > > > > > 1-2 ${MY_PV})/${MY_P}.tar.bz2" > > > > >=20 > > > > > LICENSE=3D"MIT" > > > > > SLOT=3D"0" > > > > > IUSE=3D"" > > > > >=20 > > > > > S=3D"${WORKDIR}/${MY_P}" > > > > >=20 > > > > > TWISTED_PLUGINS=3D"${TWISTED_PLUGINS:-twisted.plugins}" > > > > > fi > > >=20 > > > That's what I thought when I saw that but I found that all the > > > dev-python/twisted-* packages are depending on this, so I went with > > > it. > > >=20 > > > Now I'm thinking I could instead provide functions > > > twisted-r1_twisted_src_uri and twisted-r1_twisted_build_dir used as > > >=20 > > > SRC_URI=3D"$(twisted-r1_twisted_src_uri)" > > > S=3D"$(twisted-r1_twisted_build_dir)" > > >=20 > > > in the depender ebuilds. > >=20 > > I'm more-of wondering if that conditional is really necessary useful. > > Unless I'm missing something, the non-twisted ebuilds will replace > > those variables anyway, won't them? >=20 > The dev-python/twisted-* packages do rely on this. They will set just > MY_PACKAGE=3D >=20 > And the S, SRC_URI, LICENSE, SLOT, IUSE is set by the eclass. >=20 > Other than dev-python/twisted-* packages does not match, so they need > not to override it. Well, I meant that the other packages need to set SRC_URI and stuff anyway, so they will override it anyway. But S is a fair point. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/2_V6zKsFhBxXIE5NPo.xmez Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQJ8BAEBCgBmBQJR3vmoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKl9QP/0AdgsFkTzgk1J/b5nbOqltL t0W8VwVy9KNDwH3H977/PLXsEPXtRc/8UliSxHhmO/3okWiCphwseT4OR2MOpU6E XnQm2xyXTYFnSt0Jd17PQa2YkILlDOaisJ10eMdH0Wv2LRtUT241Qtcl1dPlq/eO 4/1fpNWjWl0+fiPios69k+1bwBoeLL2cGxggaa+RMCOIwnNx8IFWLBq4pnGJb8nt xjfbouTA/RUGI4nkraL07uAl9w0Z1/l1JMen4BjyKAXCwVhJAISlQSnyWZQKsKx3 ac5ZwMqpxvkoju19LgiEfHlv12uZjo5aC2lli4Dg22LBeTQ8e97Qx1SoaRNZ+fYQ ZeRV2pCFtxj2NDoB9z6XxJYwBg8sQ8fnBtULPhIB9CZUGPBxmvRQ6AxHiswgqjlg XZqIeFFv9gzkjrDwM5Tvj8GqVNGNYR52nDlw/bSOnf63m94/rx8famNQHUztg+qu P9G8zc9J7MWS1cbzquMZ8vc6WCYWd3R/zEpBkwxe2t42SC0UZeppt6TBl+2lUIoB K5BBBdZoL+gDj/tBvYx7H0DRYQOBDRtvgOg+KpgqsTXiZSc43jlCYXEf59paj9Zi MbFgWK+6kTozyA6TD4cinKIgNyyE7FIObYvH6sZvCoLcp8iDEmRkaBOmE7Sz/6NT 9j65l1Ks+5SlCnFHzKAC =YwQ2 -----END PGP SIGNATURE----- --Sig_/2_V6zKsFhBxXIE5NPo.xmez--