[gentoo-dev] Re: [1/3] Automatic *XML->Wiki wiki.gentoo.org

["Steven J. Long" <slong@rathaus.eclipse.co.uk>]

Sven Vermeulen wrote:
> I did some additional work on the style (as well as making a small wrapper
> script to simplify handling it). There are still some issues that I need to
> sort out, but I hope I can do that the coming days.
> 
> I keep track of the stuff at [1], an example output can already be found at
> [2]. 
> 
> [1] https://wiki.gentoo.org/wiki/User:SwifT/proj2wiki 
> [2] https://wiki.gentoo.org/wiki/User:SwifT/proj2wiki/test
> 
> It would appreciate some feedback - things that do not need to be covered
> anymore or so (I know our wiki supports some stuff that shouldn't be
> rendered anymore).
> 
> No promises, but everything I know can help ;)
> 
> btw, the tool actually converts GuideXML, so I'll be updating it later on to
> support better moves of our documentation as well.

Very nice work. The hardened test-conversion is very clean, and works well.

The sh makes me twitch though. typeset a=$foo # is easier as: a=$foo # as well
as being more portable. [ ] is part of POSIX sh (test is only still necessary
in autoconf due to its ill-advised usage of m4, afaic) and you don't quote a lot
of the parameter-expansions.

-- 
#friendly-coders -- We're friendly, but we're not /that/ friendly ;-)