[gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[Jeroen Roovers]

For a good while now, I have been obsoleting ebuild attachments on as
yet unassigned bug reports and pasting proper unified diffs into
comments. I have been doing this so that the maintainers of these
ebuilds see the actual changes instead of a giant blob of code that the
submitter of the ebuild might want to see in the tree replacing the
original ebuild. Previously I also posted a notice asking submitters to
post unified diffs instead of entire ebuilds, but this didn't have a
noticeable effect so I discontinued that practice in favour of
just posting the unified diffs.

Unfortunately, this means that I sometimes get credit for posting
such comments. Please make note of the ebuild/diff replacement and
attribute the changes correctly to the submitter, not the messenger. I
shouldn't be getting the credit for them at all.


Regards,
     jer

Re: [gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[Rich Freeman]

On Thu, Jul 4, 2013 at 10:50 AM, Jeroen Roovers <jer@gentoo.org> wrote:
> Unfortunately, this means that I sometimes get credit for posting
> such comments. Please make note of the ebuild/diff replacement and
> attribute the changes correctly to the submitter, not the messenger. I
> shouldn't be getting the credit for them at all.

All the same, thanks for adding value!

Rich

Re: [gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[Fabian Groffen]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On 04-07-2013 16:50:51 +0200, Jeroen Roovers wrote:
> Unfortunately, this means that I sometimes get credit for posting
> such comments. Please make note of the ebuild/diff replacement and
> attribute the changes correctly to the submitter, not the messenger. I
> shouldn't be getting the credit for them at all.

Sorry!  I guess your efforts (which are really appreciated!) just mean
bug reports should be read more thoroughly ... mea culpa.

Thanks again for the effort anyway,
Fabian

-- 
Fabian Groffen
Gentoo on a different level

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[Brian Dolbec]

On Thu, 2013-07-04 at 16:50 +0200, Jeroen Roovers wrote:
> For a good while now, I have been obsoleting ebuild attachments on as
> yet unassigned bug reports and pasting proper unified diffs into
> comments. I have been doing this so that the maintainers of these
> ebuilds see the actual changes instead of a giant blob of code that the
> submitter of the ebuild might want to see in the tree replacing the
> original ebuild. Previously I also posted a notice asking submitters to
> post unified diffs instead of entire ebuilds, but this didn't have a
> noticeable effect so I discontinued that practice in favour of
> just posting the unified diffs.
> 
> Unfortunately, this means that I sometimes get credit for posting
> such comments. Please make note of the ebuild/diff replacement and
> attribute the changes correctly to the submitter, not the messenger. I
> shouldn't be getting the credit for them at all.
> 
> 
> Regards,
>      jer
> 


Thank you for the extra effort.  I appreciate it, although for the one I
had recently, it made it harder.  I had just migrated the ebuild to the
new python eclasses. So the diff included the reversal of those changes
too.
-- 
Brian Dolbec <dolsen@gentoo.org>

Re: [gentoo-dev] Patches on bug reports: thanks but no thanks for the credit

[Jeroen Roovers]

On Thu, 04 Jul 2013 09:31:35 -0700
Brian Dolbec <dolsen@gentoo.org> wrote:
> Thank you for the extra effort.  I appreciate it, although for the
> one I had recently, it made it harder.  I had just migrated the
> ebuild to the new python eclasses. So the diff included the reversal
> of those changes too.

That happened during morning coffee. An honest mistake.


     jer