From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id DC8F11381F3 for ; Wed, 3 Jul 2013 12:46:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 938FFE09AF; Wed, 3 Jul 2013 12:46:05 +0000 (UTC) Received: from juliette.telenet-ops.be (juliette.telenet-ops.be [195.130.137.74]) by pigeon.gentoo.org (Postfix) with ESMTP id 7887DE09A4 for ; Wed, 3 Jul 2013 12:46:04 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by juliette.telenet-ops.be with bizsmtp id vom31l00A2khLEN06om3ST; Wed, 03 Jul 2013 14:46:03 +0200 Date: Wed, 3 Jul 2013 14:42:56 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Re: [gentoo-kernel] Proper distribution integration of kernel *-sources, patches and configuration. Message-ID: <20130703144256.68e4aef8@TOMWIJ-GENTOO> In-Reply-To: <20130703104555.GA9789@rathaus.eclipse.co.uk> References: <20130701164149.131490f8@TOMWIJ-GENTOO> <20130701181749.GA3831@kroah.com> <20130701205615.18fdcea2@TOMWIJ-GENTOO> <20130701212542.60f86307@TOMWIJ-GENTOO> <20130701193330.GA31073@kroah.com> <20130701215045.5f8099d3@TOMWIJ-GENTOO> <20130703104555.GA9789@rathaus.eclipse.co.uk> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.19; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/OB9lKEb5raTffSeA4edVGnZ"; protocol="application/pgp-signature" X-Archives-Salt: 12ab903a-b0ad-46b3-89c9-0b5dded3bb7c X-Archives-Hash: 6f4e08b39f54de2a4797f1958ae79291 --Sig_/OB9lKEb5raTffSeA4edVGnZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 3 Jul 2013 11:45:55 +0100 "Steven J. Long" wrote: > Tom Wijsman wrote: > > > > Earlier I mentioned "3) The patch should not affect the build by > > > > default."; if it does, we have to adjust it to not do that, > > > > this is something that can be easily scripted. >=20 > If it does then it should never be applied, unless the user > specifically asks for it, imo, and the resultant kernel is labelled > -exp as you suggest. Yes, we are going to introduce an experimental USE flag for this. > > It's just a matter of > > > > embedding each + block in the diff with a config check and > > > > updating the counts. > > >=20 > > > Wonderful, now you are maintaining a patch that looks nothing > > > like the one created by the original developers, nor tested by > > > anyone else other than gentoo developers. > >=20 > > I can convert the original developer's patch whenever he updates > > it; or on top of that, write a script to generate the original > > patch back. >=20 > Please, just keep a copy of the original patch as well as the modified > output from the script, somewhere reasonable to you, if you are doing > any editing. Traceability is essential here. The need to keep duplicates around is a broken design; if you would need to do this, there is something worse going on. But yes, some git branches can easily cover the editing part. > Personally I think it ill-advised, and would prefer simply that the > patch were not applied if the above process in your testing prior to > usage, showed that it would affect other parts of the build > inappropriately, even when configured off. Or it's known to do so, > like aufs. Maybe, we can hear whether the patch authors want to do something about this, so we don't have to convert patches like this; maybe most of them are willing to do this without a problem. Though, there are going to be parts that they want to unconditionally apply, which is why we will need to wrap those parts with a check. > Unless of course the user specifically requests it. This can be a > simple variable with a list of required patches, or whatever. With USE=3D-experimental (which will be the default) they are excluded by default, after enabling that the user can exclude patches by setting UNIPATCH_EXCLUDE through the package.env mechanism. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/OB9lKEb5raTffSeA4edVGnZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQEcBAEBAgAGBQJR1BxTAAoJEJWyH81tNOV9j0IH/icNNBIDu8St8KnIu/2u7CsK NaIr2q8SQ9m5DaAZvvp+kaB26ix2Lm/NJSNyRHNZ7dbbGHCStgo9Qlbcc0dQaP+5 8G2nerIFZf2tn+6JCpuXjvqmBDowNLIMvUkcGRlb1zfZVPIRnJP68Z81MPV5r9Ad r0Gbu7w3GkulqIfWA77CfXUdN1NhJxICbdOCuULpjyjSJ3MXLR9Y1roIZlMH8PLE KFsBREffzFtPc043MpgpHJ1TIe98qx1qwmnHEvhg9gocUOOF4COvwnT7/pMcC03o rejcuzm/333KssuixMkzmHcnd/fCWFaXUGFo+bD3kAAhQVRgdqQ9OlOWRpc3g+o= =GmwH -----END PGP SIGNATURE----- --Sig_/OB9lKEb5raTffSeA4edVGnZ--