From: Tom Wijsman <TomWij@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: Re: [gentoo-kernel] Proper distribution integration of kernel *-sources, patches and configuration.
Date: Wed, 3 Jul 2013 14:42:56 +0200 [thread overview]
Message-ID: <20130703144256.68e4aef8@TOMWIJ-GENTOO> (raw)
In-Reply-To: <20130703104555.GA9789@rathaus.eclipse.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2577 bytes --]
On Wed, 3 Jul 2013 11:45:55 +0100
"Steven J. Long" <slong@rathaus.eclipse.co.uk> wrote:
> Tom Wijsman wrote:
> > > > Earlier I mentioned "3) The patch should not affect the build by
> > > > default."; if it does, we have to adjust it to not do that,
> > > > this is something that can be easily scripted.
>
> If it does then it should never be applied, unless the user
> specifically asks for it, imo, and the resultant kernel is labelled
> -exp as you suggest.
Yes, we are going to introduce an experimental USE flag for this.
> > It's just a matter of
> > > > embedding each + block in the diff with a config check and
> > > > updating the counts.
> > >
> > > Wonderful, now you are maintaining a patch that looks nothing
> > > like the one created by the original developers, nor tested by
> > > anyone else other than gentoo developers.
> >
> > I can convert the original developer's patch whenever he updates
> > it; or on top of that, write a script to generate the original
> > patch back.
>
> Please, just keep a copy of the original patch as well as the modified
> output from the script, somewhere reasonable to you, if you are doing
> any editing. Traceability is essential here.
The need to keep duplicates around is a broken design; if you would
need to do this, there is something worse going on. But yes, some git
branches can easily cover the editing part.
> Personally I think it ill-advised, and would prefer simply that the
> patch were not applied if the above process in your testing prior to
> usage, showed that it would affect other parts of the build
> inappropriately, even when configured off. Or it's known to do so,
> like aufs.
Maybe, we can hear whether the patch authors want to do something about
this, so we don't have to convert patches like this; maybe most of them
are willing to do this without a problem. Though, there are going to be
parts that they want to unconditionally apply, which is why we will
need to wrap those parts with a check.
> Unless of course the user specifically requests it. This can be a
> simple variable with a list of required patches, or whatever.
With USE=-experimental (which will be the default) they are excluded by
default, after enabling that the user can exclude patches by setting
UNIPATCH_EXCLUDE through the package.env mechanism.
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-07-03 12:46 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 14:41 [gentoo-dev] Proper distribution integration of kernel *-sources, patches and configuration Tom Wijsman
2013-07-01 15:14 ` Ben de Groot
2013-07-01 15:20 ` [gentoo-dev] Re: [gentoo-kernel] " Jeff Horelick
2013-07-01 18:30 ` Anthony G. Basile
2013-07-01 19:07 ` Tom Wijsman
2013-07-01 19:24 ` Greg KH
2013-07-01 19:40 ` Tom Wijsman
2013-07-01 19:55 ` Fabio Erculiani
2013-07-01 19:59 ` Pacho Ramos
2013-07-01 20:03 ` Fabio Erculiani
2013-07-01 20:06 ` Tom Wijsman
2013-07-01 20:24 ` Christoph Junghans
2013-07-01 20:27 ` Fabio Erculiani
2013-07-01 20:25 ` Rick "Zero_Chaos" Farina
2013-07-01 21:18 ` Anthony G. Basile
2013-07-01 16:20 ` [gentoo-dev] " Rick "Zero_Chaos" Farina
2013-07-01 16:28 ` hasufell
2013-07-01 17:35 ` Tom Wijsman
2013-07-01 17:52 ` Rick "Zero_Chaos" Farina
2013-07-05 0:19 ` Mike Pagano
2013-07-17 21:11 ` Donnie Berkholz
2013-07-01 18:17 ` [gentoo-dev] Re: [gentoo-kernel] " Greg KH
2013-07-01 18:38 ` Markos Chandras
2013-07-01 18:56 ` Tom Wijsman
2013-07-01 19:09 ` Matthew Summers
2013-07-01 19:25 ` Tom Wijsman
2013-07-01 19:33 ` Greg KH
2013-07-01 19:50 ` Tom Wijsman
2013-07-03 10:45 ` [gentoo-dev] " Steven J. Long
2013-07-03 12:42 ` Tom Wijsman [this message]
2013-07-04 2:00 ` Walter Dnes
2013-07-04 5:37 ` [gentoo-dev] " Steven J. Long
2013-07-04 7:41 ` [gentoo-dev] " Tom Wijsman
2013-07-04 5:27 ` [gentoo-dev] " Steven J. Long
2013-07-04 7:57 ` Tom Wijsman
2013-07-05 8:38 ` Steven J. Long
2013-07-05 9:04 ` Tom Wijsman
2013-07-09 15:12 ` Steven J. Long
2013-07-01 20:14 ` Markos Chandras
2013-07-01 20:25 ` Fabio Erculiani
2013-07-01 21:26 ` Anthony G. Basile
2013-07-01 21:30 ` Fabio Erculiani
2013-07-01 21:55 ` Anthony G. Basile
2013-07-01 20:31 ` Tom Wijsman
2013-07-01 18:45 ` Tom Wijsman
2013-07-01 19:23 ` Greg KH
2013-07-01 19:33 ` Tom Wijsman
2013-07-01 21:17 ` Anthony G. Basile
2013-07-01 21:24 ` Greg KH
2013-07-01 21:53 ` Anthony G. Basile
2013-07-02 8:31 ` gentoo-checkconf script " Michael Weber
2013-07-03 11:40 ` [gentoo-dev] Re: gentoo-checkconf script " Steven J. Long
2013-07-01 21:55 ` [gentoo-dev] " Tom Wijsman
2013-07-02 1:36 ` Richard Yao
2013-07-02 1:44 ` Richard Yao
2013-07-02 1:56 ` Greg KH
2013-07-02 3:29 ` Richard Yao
2013-07-02 3:40 ` Richard Yao
2013-07-02 19:39 ` Greg KH
2013-07-02 3:31 ` Richard Yao
2013-07-02 7:36 ` [gentoo-dev] " Sergei Trofimovich
2013-07-02 8:21 ` Fabio Erculiani
2013-07-02 8:37 ` Michael Weber
2013-07-02 8:52 ` Michael Weber
2013-07-02 18:16 ` Sergei Trofimovich
2013-07-03 13:06 ` Tom Wijsman
2013-07-03 13:52 ` Sergei Trofimovich
2013-07-03 15:18 ` Tom Wijsman
2013-07-03 16:10 ` Sergei Trofimovich
2013-07-02 10:08 ` Tom Wijsman
2013-07-02 21:48 ` Tomáš Pružina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703144256.68e4aef8@TOMWIJ-GENTOO \
--to=tomwij@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox