From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F0A551381F3 for ; Wed, 3 Jul 2013 11:39:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 457E1E0968; Wed, 3 Jul 2013 11:39:20 +0000 (UTC) Received: from smtpout.karoo.kcom.com (smtpout.karoo.kcom.com [212.50.160.34]) by pigeon.gentoo.org (Postfix) with ESMTP id D5958E08C2 for ; Wed, 3 Jul 2013 11:39:18 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.87,987,1363132800"; d="scan'208";a="22311197" Received: from unknown (HELO rathaus.eclipse.co.uk) ([109.176.215.56]) by smtpout.karoo.kcom.com with ESMTP; 03 Jul 2013 12:39:02 +0100 Date: Wed, 3 Jul 2013 12:40:59 +0100 From: "Steven J. Long" To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: gentoo-checkconf script Re: Re: [gentoo-kernel] Proper distribution integration of kernel *-sources, patches and configuration. Message-ID: <20130703114059.GB9789@rathaus.eclipse.co.uk> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20130701164149.131490f8@TOMWIJ-GENTOO> <20130701181749.GA3831@kroah.com> <20130701204516.6151bb40@TOMWIJ-GENTOO> <20130701192324.GA30808@kroah.com> <51D1F1D3.8030402@gentoo.org> <20130701212454.GA32077@kroah.com> <51D1FA72.4070405@gentoo.org> <51D28FE2.90402@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51D28FE2.90402@gentoo.org> X-Archives-Salt: 3a128160-4423-4168-975e-1262500d9dab X-Archives-Hash: 3c0c0fb4620e0fa950a9577494dd84ff Michael Weber wrote: > Anthony G. Basile wrote: > > Now I'm confused because gentoo-sources is gentoo specific. It > > contains stuff that we need in gentoo but other distros do not > > need, like our end-to-end support for certain xattr namespaces. If > > you remove these then we must either 1) maintain a userland which > > is not in line with other distros or 2) give up on critical > > features we want in gentoo, like markings on elf object in > > user.pax.flags and certain caps, as well as in the future > > preserving selinux labels through emerge. Upstream will not accept > > them because of "who needs that crap" and we can't give them up > > without loosing core functionality. Feel free to review those > > patches but don't ask us to drop them from gentoo-sources because > > their not in upstream. Indeed. Every distro has their own kernel patches, and to all sorts of software. That's why we use it, since things are integrated, and in Gentoo we get as close to upstream as possible, while still useful. > What about a check-kernel-config-for-gentoo-compliance script for > starterts? > > I manage a handfull of kernel configs over some years (laptop vs. > server, graphics, firewalling capabilities) and was always tempted to > write an script to check if the config meets a certain set of > requirements. I think of "xattr", "selinux", "gentoo-boot" and so on, That makes sense. > that can be expanded by users demand, like, "CONFIG_CMDLINE should > include" and "CONFIG_DEFAULT_HOSTNAME=x" and "all iptables target on". Something like this? $KBUILD_SRC=${1:-.} # default user check function usr_config_check(){ : } user_script=$KBUILD_SRC/gentoo-user-check if [ -f $user_script ]; then # allow user to override settings . "$user_script" || die "unable to source user script: $user_script" fi ..main script.. usr_config_check "$VERSION" "$PATCHLEVEL" etc.. || die "failed user check" ..cleanup.. exit 0 > An additional make target in gentoo-sources could the warn about any > missing feature, and ask for "yes" or wait some seconds. > (I remember reaging some funny note about my kernel supporting x32 but > by userland not, like that kernel build would run on that userland) Yeah, if it ran after config, it could do simple checks at least, to begin with. Looking at linux/Makefile, we could just add: $(Q)gentoo-check-config "$KBUILD_SRC" after: $(Q)$(MAKE) $(build)=scripts/kconfig $@ ..in config. I'm not sure if you'd need it for %config case as well; I don't see the need in the context of overall sanity checks. It would be useful though, to check for required things like {DEV,}TMPFS -- #friendly-coders -- We're friendly, but we're not /that/ friendly ;-)