From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 13D331381F3 for ; Mon, 1 Jul 2013 19:33:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 663C0E0B02; Mon, 1 Jul 2013 19:33:34 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3442CE0AF8 for ; Mon, 1 Jul 2013 19:33:33 +0000 (UTC) Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id ECEA220B91 for ; Mon, 1 Jul 2013 15:33:31 -0400 (EDT) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute3.internal (MEProxy); Mon, 01 Jul 2013 15:33:31 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:content-type:in-reply-to; s=smtpout; bh=RoM7ae2Uf30ryIY9ZCoBVX6i7eU=; b=BCIg+pYarhSdmcRGm9t5eMwhKAFA iloDbsq8lrUn0DqJLIk7edpDeCFtGVamSVbKP+FxKp7P463Evl1ykYNYTwvPAHNv qu1qMnwYipCWuCAhzTuyX0YHmu4aCMiS6MkoP6a6PtsKxdG0teMG/pDQctl+ydK5 GDB9l46Rcv18xdA= X-Sasl-enc: OF6mKc+1hTwok5fOdaZ/vKBv/RIgpeDcvJxmoOJIu7lz 1372707211 Received: from localhost (unknown [76.28.172.123]) by mail.messagingengine.com (Postfix) with ESMTPA id 99361680245; Mon, 1 Jul 2013 15:33:31 -0400 (EDT) Date: Mon, 1 Jul 2013 12:33:30 -0700 From: Greg KH To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-kernel] Proper distribution integration of kernel *-sources, patches and configuration. Message-ID: <20130701193330.GA31073@kroah.com> References: <20130701164149.131490f8@TOMWIJ-GENTOO> <20130701181749.GA3831@kroah.com> <20130701205615.18fdcea2@TOMWIJ-GENTOO> <20130701212542.60f86307@TOMWIJ-GENTOO> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130701212542.60f86307@TOMWIJ-GENTOO> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: eb5170d3-1b6e-4db3-bb5e-78956f4dba27 X-Archives-Hash: b1855a8b859c7c8d1506ebe86fd1dbd3 On Mon, Jul 01, 2013 at 09:25:42PM +0200, Tom Wijsman wrote: > On Mon, 1 Jul 2013 14:09:57 -0500 > Matthew Summers wrote: > > If the patchset patches the kernel's core, it doesn't matter what > > CONFIG_* option is set the core kernel code _has_now_been_changed_. > > This is the crux of the argument, I believe. AUFS simply being one > > example of this. I'm sure there are others. > > As per my response to that point, this statement is no longer true. > > Let me re-iterate it here: > > Earlier I mentioned "3) The patch should not affect the build by > default."; if it does, we have to adjust it to not do that, this is > something that can be easily scripted. It's just a matter of embedding > each + block in the diff with a config check and updating the counts. Wonderful, now you are maintaining a patch that looks nothing like the one created by the original developers, nor tested by anyone else other than gentoo developers. There's a reason that no other distro does this. Playing fast-and-loose with kernel patches is a fun thing to do, but really, why? Users love doing this type of thing, but the interactions of different kernel patches with core subsystems is almost always a non-trivial thing. I'm not saying not to do this, but consider this a friendly warning that this is going to be a MAJOR pain to maintain and debug over the long-run. But hey, what do I know? It's not like I've ever done this before and had the experience of the resulting fall-out that took years to recover from on user's production systems, causing a number of enterprise Linux companies to swear that they would never do this type of thing again... Personally, I wish you luck, it will push the sane users to the vanilla-sources tree, which I strongly encourage :) greg "kids, get off my lawn!" k-h