public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: phajdan.jr@gentoo.org
Subject: Re: [gentoo-dev] repoman commit unexpectedly drops FEATURES="sign" on error
Date: Sun, 23 Jun 2013 10:19:38 +0200	[thread overview]
Message-ID: <20130623101938.63f2fe7d@gentoo.org> (raw)
In-Reply-To: <51C63B30.7030002@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Dnia 2013-06-22, o godz. 17:02:56
""Paweł Hajdan, Jr."" <phajdan.jr@gentoo.org> napisał(a):

> On 6/20/13 2:16 AM, Michał Górny wrote:
> > Doing test signatures won't cover all failures.
> 
> Do you know an example? The only one I'm aware of is when a test
> signature is made very close to the expiration date, and then the real
> signature would be done after it.

Well, Michael explained one in the other branch of this thread quite
thoroughly. Other than that, there can be random runtime errors
and race conditions.

I'd say it's as good as using stat() to check whether a file exists
before opening it. But thinking of it, I've got another idea...

How about opening 'gpg -s' in a subprocess before first commit
and feeding the Manifest afterwards? As far as I can see, gpg asks for
the password instantly, so likely most of the bases will be covered
already, and we're be doing a single signature only.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

  reply	other threads:[~2013-06-23  8:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  2:59 [gentoo-dev] repoman commit unexpectedly drops FEATURES="sign" on error "Paweł Hajdan, Jr."
2013-06-20  3:25 ` Zac Medico
2013-06-20  3:27   ` Zac Medico
2013-06-20  6:39     ` Michael Weber
2013-06-20  9:16 ` Michał Górny
2013-06-23  0:02   ` "Paweł Hajdan, Jr."
2013-06-23  8:19     ` Michał Górny [this message]
2013-06-23 21:06       ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130623101938.63f2fe7d@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=phajdan.jr@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox