On Friday 21 June 2013 20:06:31 Robin H. Johnson wrote: > On Fri, Jun 21, 2013 at 07:40:03PM -0400, Mike Frysinger wrote: > > On Friday 21 June 2013 14:50:54 Robin H. Johnson wrote: > > > From what I've read on the list recently, there's a lot of demand for > > > non-maintainer updates to ebuilds. Esp. with the upcoming Git > > > migration, I predict there will be a much larger influx of changes > > > from users. > > > > seems like we're somewhat approaching it the wrong way around. > > [Snip giant suggestions re gerrit/review-systems] > > I'm not going into review systems here at all, I'm simply trying to have > a policy of what changes are welcomed/blocked WITHOUT interaction from > the listed maintainer(s) of a given package/herd. add a new field to metadata.xml that declares the state. make it an enum: ANYTHING_GOES (the default) REQUIRES_HERD REQUIRES_MAINTAINER > If they have to ask me to review a trivial patch, I've already failed > them. I don't want ANY gatekeeping, I want them to go and commit it > already. > > Then extending THAT to Gerrit, who is responsible/allowed to hit that > web interface submit button? have gerrit check metadata.xml and see if the policy declared in there lines up with the gerrit approvals attained. blam, done. -mike