From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AE4AC1381F3 for ; Mon, 17 Jun 2013 05:55:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 89FF8E0944; Mon, 17 Jun 2013 05:55:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A077AE093A for ; Mon, 17 Jun 2013 05:55:04 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id C697633D8CC; Mon, 17 Jun 2013 05:55:03 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] unpacker.eclass extensions Date: Mon, 17 Jun 2013 01:55:09 -0400 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: "Vadim A. Misbakh-Soloviov" , azamat.hackimov@gmail.com References: <51BC282E.9020306@mva.name> In-Reply-To: <51BC282E.9020306@mva.name> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3449715.rY3X6gpHzQ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201306170155.10347.vapier@gentoo.org> X-Archives-Salt: f2b0d984-e5f8-47bb-a9b4-5e33c26bf5c1 X-Archives-Hash: ff815b37d7074d67c43f00ff7ff4d3b9 --nextPart3449715.rY3X6gpHzQ Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 15 June 2013 04:39:10 Vadim A. Misbakh-Soloviov wrote: > # @DESCRIPTION: > # Unpack nixstaller generated files needs a period at the end. content in @DESCRIPTION is normalized. > # They're shell scripts with the blob package tagged onto > # the end of the archive. In the blob placed tarballs with > # actual content. "They're shell scripts with a tarball appended to them." > # Please note, if you need additional dependecies make sure to unpack > subarch > # archive as first argument. no idea what this means > nixstaller_unpack() { this does not follow the API naming convention ("unpack" comes first) > local unpack_files=3D"$@" this doesn't work. you normalized the input into a string. just inline th= e=20 "$@" below. or don't specify it at all ... this does the same thing (albei= t,=20 correctly): local src for src ; do > unpack_banner "$i" > # Make sure that file exists > [[ -f "./$i" ]] && ( > local type=3D$(file -b ${i}) > case ${type} in > data) > tar -xJf "./$i" why doesn't the bzip2 detect as bzip2 ? > ;; > gzip*) > tar -xzf "./$i" > ;; > esac > ) || die "Failed to unpack $i" the subshell should go away -- you don't even need it: [[ $? -eq 0 ]] || die ... i wish we could merge with the file detection in unpack_makeself somehow =2Dmike --nextPart3449715.rY3X6gpHzQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRvqS+AAoJEEFjO5/oN/WBPcQQANtQv0jHGVHScdfAFkGZvERx 8Ggz0Rl0471xIKqbv8leTO2EkAn0+T3QlvML5Xt+2QcGSQ0rxct0d7nB75j5gY+Y r4jYA8k1HX8WUdt5WYqbEiKTOb/UxT9j0Zuw6K9lOeuh1VkZ4HWXeHl5GYxZ5XQW VXyLeqK5uFITKUdYrjpyJ3c6PV/o0M6ZDf7JaHG8hrPmkpjtqCFtaukOCQo9AifG b65w0BJZpKl1EM0sEfEeMACBzePNngKb8AfuqVlPrfhcfyDKYiewox3LxSRP0xPb uf7ab7Vbs9harSGXg1CvDiBFgSXwRVQ59Ffh8C79Gjl/dVZXq5lz4UMA5OlkXZon BK87m0KXM0Use4rHX3NL9MclxdK3vFX1GyGg1nCAgSDAeRjvg68mM1SDRsrXjDyh CVmq2wbR9VAEeA5AvG03aT3WbHp6WRpnJd9j6eWW2jiUmZ3reJEDlxsigCBxjme6 zcvyyVnv3ba4nzpt0KLrjBLVYYtRIe3GWHoNhYkBo0qS6IMH0uifIDk0ZhyOBvj0 aY5E5GE6qhsNKXfHDiuYts22U2gHb8O6G7QdDNNtHgkI9/0ZRWt8lR2/PJqJNHGv XBZ1e90kVJLnj8QOj94xtCaFCwMW9L5Vo/9WZJc6hhSWSoUrLT89l3M7vySKSOhb t6UyALlCgWfPJCSlro6X =KJHC -----END PGP SIGNATURE----- --nextPart3449715.rY3X6gpHzQ--