From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 139A01381F3 for ; Mon, 17 Jun 2013 05:45:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8F439E0848; Mon, 17 Jun 2013 05:45:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 73A20E07F0 for ; Mon, 17 Jun 2013 05:45:14 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 74F2633DEE1 for ; Mon, 17 Jun 2013 05:45:13 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] evar_push/pop helpers Date: Mon, 17 Jun 2013 01:45:19 -0400 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) References: <201306012303.21261.vapier@gentoo.org> <201306020329.34579.vapier@gentoo.org> <20130602094817.786a879d@TOMWIJ-GENTOO> In-Reply-To: <20130602094817.786a879d@TOMWIJ-GENTOO> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7977399.CcL1YODDO2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201306170145.19923.vapier@gentoo.org> X-Archives-Salt: 757d2c2d-5606-4272-b6b7-0b5faad7756e X-Archives-Hash: 19a3b753a8646190bf79f05fe79e6862 --nextPart7977399.CcL1YODDO2 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 02 June 2013 03:48:17 Tom Wijsman wrote: > On Sun, 2 Jun 2013 03:29:33 -0400 Mike Frysinger wrote: > > except you aren't handling edge cases (like set vs unset) >=20 > You've got me there, though this is quite an exception; I don't see > why we have to introduce something that's barely used... >=20 > `qgrep -eH '^\s*\bset\b' | wc -l` > yields 150 >=20 > `qgrep -eH '^\s*\bset\b' | sed 's/:.*//g' | sed > 's/\/[a-zA-Z0-9_.-]*$//g' | sort -u | wc -l` > yields 34 >=20 > Only 34 packages, and do these all _really_ need a 'set'? I doubt it. i've got at least 4 consumers in mind, and that's more than enough imo to=20 implement it right than half-ass it every time > > > Much like fixing tiny bug and trying to > > > avoid checking whether anything else is affected. > >=20 > > yeah, because forcing specific behavior for an entire function is > > always the correct answer. it's like telling people to export > > LC_ALL=3DC in make.conf so they never hit locale related problems. >=20 > Actually, bug wranglers stopped asked for English build logs because > setting LC_ALL=3DC ended up breaking things. i know it doesn't work which is why i was providing it as an example =2Dmike --nextPart7977399.CcL1YODDO2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRvqJvAAoJEEFjO5/oN/WBXqAP/j/x9lrqGfrs9YBFCbu09Bwl B79viZHo65gDrvrrtAhB5VCI9iW5nX9ZL7AtkmlNqWJv0zfA8OFTZ1eP8b3dcN9A 7hzKR8LyG0/kv823BXsSg7iIgk8m9adZv3vtHHHDVsKOhiG5fZorHw4RsdecDCVV CcMq3pVWyuaFpY6DoP57iRIjLHCNcPieswVUUmcrSdq9+HaMaA3NLqdfJk0w/30v adjNxj1egnM/HnK5tSd20u2KkSwuJsW3hlebsf12y3Aq2vb6BuEgg60Z0D/DVDJj qsl+u/BgnRnpEjyC2cPe8wnaKXJn3K/K7jcQG5YXxwT1yZRnccupCSNyYlVWCQXX qwsMWgX9XZ1IKDG9M/h+PtIunIuPxUGoOjcJSudGc96I2j35hQ4euRaWtiYyaYXT HwakFFIyVVHZN3eJwtp0nbqfFdDNgL/1JdNcFQ/Sbfr34CrDTPZ3bI7pRiMDV63s IOxXekbftAMRAJZ/7nI2PWjf6HqqlCQXl8Z9wA8jnGexTH60k/wKQ7HwucPjj7Bm J6nqDLr7/N2e6FzioK9zHiU3mTXn+PoTj7YNQufjdN9WE606YddrZoXhSbecvHOz 5upI5SuWIECm8E/76Y109bsGj160ggwsgl3b2YPQSuHz5+ZkAXWjWv1SIZrh1Wkb fn0dpVtu0NiHbxTwJBZF =NkM6 -----END PGP SIGNATURE----- --nextPart7977399.CcL1YODDO2--