[gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[Chris Reffett]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

All,
At the beginning of July, the KDE team will be removing EAPI 0/1
support from cmake-utils.eclass and inlining the functions from
base.eclass in order to remove that inherit [1]. The modified eclass
is currently available in the KDE overlay. There is one package [2]
remaining in-tree which has EAPI<2 which will be handled soon, but
please update any overlay packages using the eclass. I have also added
a deprecation warning to the in-tree cmake-utils.eclass for packages
using EAPI 0/1.


Chris Reffett


[1] https://bugs.gentoo.org/show_bug.cgi?id=459678
[2] https://bugs.gentoo.org/show_bug.cgi?id=460572
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iKYEARECAGYFAlG6PmRfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1QIkgCfV+VLuCg3bC880EhaTiol4ggB
jhQAoJaBwxZHwH9l4g48olShsnWDZBos
=qeh9
-----END PGP SIGNATURE-----

Re: [gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[Alexis Ballier]

> At the beginning of July, the KDE team will be removing EAPI 0/1
> support from cmake-utils.eclass and inlining the functions from
> base.eclass in order to remove that inherit [1]. 

So, instead of fixing what you consider wrong in base.eclass, you inline
it so that if someone improves base.eclass he has to do it for
cmake-utils too?

Re: [gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[Chris Reffett]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/13/2013 06:37 PM, Alexis Ballier wrote:
>> At the beginning of July, the KDE team will be removing EAPI 0/1
>>  support from cmake-utils.eclass and inlining the functions from
>>  base.eclass in order to remove that inherit [1].
> 
> So, instead of fixing what you consider wrong in base.eclass, you 
> inline it so that if someone improves base.eclass he has to do it 
> for cmake-utils too?
> 
We did not actually inline most of the complicated logic from
base.eclass, as to the best of my knowledge epatch itself will handle
all of the corner cases that base_src_prepare covers. The new patching
code essentially consists of [[ ${PATCHES[@]} ]] && epatch
"${PATCHES[@]}"; epatch_user. As for the reason for the change, the
request and rationale can be seen in the first bug that I linked in
the email.

Chris Reffett
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iKYEARECAGYFAlG6TDVfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1S3SACgitmH0FVRUNwmJE9e/4JmrwqV
ucwAnj+/+V9ECy9OoCK6eDqSsuiiTgDU
=5QKk
-----END PGP SIGNATURE-----

Re: [gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[Alexis Ballier]

On Thu, 13 Jun 2013 18:48:21 -0400
Chris Reffett <creffett@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 06/13/2013 06:37 PM, Alexis Ballier wrote:
> >> At the beginning of July, the KDE team will be removing EAPI 0/1
> >>  support from cmake-utils.eclass and inlining the functions from
> >>  base.eclass in order to remove that inherit [1].
> > 
> > So, instead of fixing what you consider wrong in base.eclass, you 
> > inline it so that if someone improves base.eclass he has to do it 
> > for cmake-utils too?
> > 
> We did not actually inline most of the complicated logic from
> base.eclass, as to the best of my knowledge epatch itself will handle
> all of the corner cases that base_src_prepare covers. The new patching
> code essentially consists of [[ ${PATCHES[@]} ]] && epatch
> "${PATCHES[@]}"; epatch_user.

that kind of stuff sounds more like it should be factorized rather than
copied all around; be it base.eclass, an EAPI, or another eclass I
don't really care.


there's also a base_src_install_docs call in current cmake-utils.eclass

Alexis.

[gentoo-dev] Re: cmake-utils.eclass dropping EAPI 0/1 support

[Michael Palimaka]

On 14/06/2013 09:05, Alexis Ballier wrote:
> On Thu, 13 Jun 2013 18:48:21 -0400
> Chris Reffett <creffett@gentoo.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 06/13/2013 06:37 PM, Alexis Ballier wrote:
>>>> At the beginning of July, the KDE team will be removing EAPI 0/1
>>>>   support from cmake-utils.eclass and inlining the functions from
>>>>   base.eclass in order to remove that inherit [1].
>>>
>>> So, instead of fixing what you consider wrong in base.eclass, you
>>> inline it so that if someone improves base.eclass he has to do it
>>> for cmake-utils too?
>>>
>> We did not actually inline most of the complicated logic from
>> base.eclass, as to the best of my knowledge epatch itself will handle
>> all of the corner cases that base_src_prepare covers. The new patching
>> code essentially consists of [[ ${PATCHES[@]} ]] && epatch
>> "${PATCHES[@]}"; epatch_user.
>
> that kind of stuff sounds more like it should be factorized rather than
> copied all around; be it base.eclass, an EAPI, or another eclass I
> don't really care.

The code literally is '[[ ${PATCHES[@]} ]] && epatch "${PATCHES[@]}"'. 
Given that the actual epatch logic is in one place, I am not sure how 
much of an issue this really is. I think there's a proposal to put 
epatch into PMS too.

Best regards,
Michael

Re: [gentoo-dev] cmake-utils.eclass dropping EAPI 0/1 support

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 13 Jun 2013 17:49:24 -0400
Chris Reffett <creffett@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> All,
> At the beginning of July, the KDE team will be removing EAPI 0/1
> support from cmake-utils.eclass and inlining the functions from
> base.eclass in order to remove that inherit [1]. The modified eclass
> is currently available in the KDE overlay. There is one package [2]
> remaining in-tree which has EAPI<2 which will be handled soon, but
> please update any overlay packages using the eclass. I have also added
> a deprecation warning to the in-tree cmake-utils.eclass for packages
> using EAPI 0/1.

Running egencache manually on gentoo-x86 finishes as:

build metadata cache for '::gentoo'
 * EAPI 0 and 1 support is now deprecated.
 * If you are the package maintainer, please
 * update this package to a newer EAPI.
 * Support for EAPI 0-1 will be dropped at the beginning of July.

May I ask you to make message a bit clearer to include eclass
name and ebuild name? Like in patch attached.

The output will look like:
build metadata cache for '::gentoo'
 * app-text/zpspell-0.4.1: EAPI 0 and 1 support is now deprecated.
 * If you are the package maintainer, please
 * update this package to a newer EAPI.
 * Support for EAPI 0-1 for 'cmake-utils.eclass' will be dropped at the beginning of July.

'eqawarn' might suit better for those warnings as well.

Thanks!

- -- 

  Sergei
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iEYEARECAAYFAlG7WGUACgkQcaHudmEf86psfwCfbZ1c+fIz80Jo4a+xaYGs0oiW
RbkAn0mVqv/wXxcRTXMB14mXRmv8LYMW
=b6P1
-----END PGP SIGNATURE-----

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cmake-utils.eclass.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]

Index: cmake-utils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/cmake-utils.eclass,v
retrieving revision 1.95
diff -u -u -r1.95 cmake-utils.eclass
--- cmake-utils.eclass	13 Jun 2013 21:16:53 -0000	1.95
+++ cmake-utils.eclass	14 Jun 2013 17:28:13 -0000
@@ -65,10 +65,10 @@
 CMAKE_EXPF="src_compile src_test src_install"
 case ${EAPI:-0} in
 	2|3|4|5) CMAKE_EXPF+=" src_prepare src_configure" ;;
-	1|0) ewarn "EAPI 0 and 1 support is now deprecated."
+	1|0) ewarn "${CATEGORY}/${PF}: EAPI 0 and 1 support is now deprecated."
 		ewarn "If you are the package maintainer, please"
 		ewarn "update this package to a newer EAPI."
-		ewarn "Support for EAPI 0-1 will be dropped at the beginning of July."
+		ewarn "Support for EAPI 0-1 for 'cmake-utils.eclass' will be dropped at the beginning of July."
     ;;
 	
 	*) die "Unknown EAPI, Bug eclass maintainers." ;;