From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B826E1381F3 for ; Sun, 9 Jun 2013 07:32:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CA8F2E081D; Sun, 9 Jun 2013 07:31:54 +0000 (UTC) Received: from georges.telenet-ops.be (georges.telenet-ops.be [195.130.137.68]) by pigeon.gentoo.org (Postfix) with ESMTP id 8FD00E0804 for ; Sun, 9 Jun 2013 07:31:53 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by georges.telenet-ops.be with bizsmtp id m7Xs1l00H2khLEN067Xs4E; Sun, 09 Jun 2013 09:31:52 +0200 Date: Sun, 9 Jun 2013 09:29:25 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] repoman warning on python data_files Message-ID: <20130609092925.616f208c@TOMWIJ-GENTOO> In-Reply-To: <20130609061332.4c773f80@gentoo.org> References: <20130609061332.4c773f80@gentoo.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/QuSBvDrbhLJSGAGiO0SvQqy"; protocol="application/pgp-signature" X-Archives-Salt: c83df316-150d-4def-9ca8-6aaa8c2b8667 X-Archives-Hash: cc062cd6ee3162800ec5c844ed1bbe9a --Sig_/QuSBvDrbhLJSGAGiO0SvQqy Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 9 Jun 2013 06:13:32 +0200 yac wrote: > I have just noticed that if package is using relative paths in:: >=20 > setup.py data_files =3D ... >=20 > Then the files are installed right into /usr in case of CPython (The > exact dest is determined by sys.prefix) >=20 > So, I'm thinking it could be worthwhile to add a warning to repoman if > package is using this method as I can imagine this can be easily > overlooked when creating a new package or mostly when bumping one. repoman currently doesn't run any ebuild phases as far as I am aware. For it to be able to warn, it has to run at least the unpack phase; running the unpack phase of each ebuild in the directory is costly. For this to actually properly work, it would need to run all phases; you don't get false positives and it then can actually check the image. What good use has this? Not much. Maintainers should check the image themselves; just to name a few this includes 1) unbundling libraries, 2) checking if everything is present, 3) checking if things are missing (important run time files, doc, examples and sometimes even source), 4) checking that needed libraries (eg. readelf) are listed in DEPEND and in your case 5) checking if things are installed to the correct paths. Just one check won't make up for the others, _you_ have to check them. Although; since this is Python, maybe the Python eclasses can do that? That way you wouldn't have to introduce slower processing in repoman; since eclasses can do these QA checks at the right moment, during merge. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/QuSBvDrbhLJSGAGiO0SvQqy Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQEcBAEBAgAGBQJRtC7ZAAoJEJWyH81tNOV9+U8IAIz3fcAChR3znaFtIn1QALv+ lyrZtEPFJEXiQG+f/ksAiFoLOhPGoN8Vo6PsdH5C3tV85DILCzfYYG9bPJnfoYap 8ddI0/0De62XmIgMWvDVSgCymusrTx2Um4mpGGA+AzU1i3mA+S0A2YmK3m54cjK7 o7xFZ04bwIBdxB7SQLbYW7/6lspndyTl+Os6JR+MwPcyfe5MmbjF3LVgWnWCGFkY n3Ft5GPeyH1MFVKimz8TU26uGfKZzu0ZjzfINo0EdwHAN1j+idYjGLbiSrWthn1g BwzcWt4+nl+fOhpvgbjmQzhG9ed4yaa+fwryEljG93VHL4lm7iJRSYEkqRWmtNs= =N7v8 -----END PGP SIGNATURE----- --Sig_/QuSBvDrbhLJSGAGiO0SvQqy--