From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 02A451381F3 for ; Sun, 2 Jun 2013 07:50:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D042E08F9; Sun, 2 Jun 2013 07:50:31 +0000 (UTC) Received: from juliette.telenet-ops.be (juliette.telenet-ops.be [195.130.137.74]) by pigeon.gentoo.org (Postfix) with ESMTP id DF310E08CA for ; Sun, 2 Jun 2013 07:50:29 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by juliette.telenet-ops.be with bizsmtp id jKqU1l0012khLEN06KqUT5; Sun, 02 Jun 2013 09:50:28 +0200 Date: Sun, 2 Jun 2013 09:48:17 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] evar_push/pop helpers Message-ID: <20130602094817.786a879d@TOMWIJ-GENTOO> In-Reply-To: <201306020329.34579.vapier@gentoo.org> References: <201306012303.21261.vapier@gentoo.org> <201306020309.31841.vapier@gentoo.org> <20130602091653.2da17286@gentoo.org> <201306020329.34579.vapier@gentoo.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/yf+a1cP3+3l8L_vCwE+Mmay"; protocol="application/pgp-signature" X-Archives-Salt: 845993fa-d34b-4033-9264-4d944c759f09 X-Archives-Hash: e8a9c638a9f9b7348e6f84a04bef9deb --Sig_/yf+a1cP3+3l8L_vCwE+Mmay Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 2 Jun 2013 03:29:33 -0400 Mike Frysinger wrote: > except you aren't handling edge cases (like set vs unset) You've got me there, though this is quite an exception; I don't see why we have to introduce something that's barely used... `qgrep -eH '^\s*\bset\b' | wc -l` yields 150 `qgrep -eH '^\s*\bset\b' | sed 's/:.*//g' | sed 's/\/[a-zA-Z0-9_.-]*$//g' | sort -u | wc -l` yields 34 Only 34 packages, and do these all _really_ need a 'set'? I doubt it. > API 101: implement it once correctly to simplify everyone else. For set this would make sense, unless someone finds a way to deal with that too; any Bash experts around here? > > Much like fixing tiny bug and trying to > > avoid checking whether anything else is affected. >=20 > yeah, because forcing specific behavior for an entire function is > always the correct answer. it's like telling people to export > LC_ALL=3DC in make.conf so they never hit locale related problems. Actually, bug wranglers stopped asked for English build logs because setting LC_ALL=3DC ended up breaking things. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/yf+a1cP3+3l8L_vCwE+Mmay Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQEcBAEBAgAGBQJRqvjBAAoJEJWyH81tNOV9E9kH/j2BytF/6JCrtgBBf+h1to5M caUdUsLhm1l21RJjqDXjqIyRIQeEfN7EFHHVbagDq5GZGgnWoD8RCKn+TmBTuQjL ALft1P0MeD6YfiNIiV3dekQyJAzmwBcrToYFbGfSRGN7HVZcCUz5lUOVY1Y39tt2 DNN6n82aS8g+Z9n9n+RxehFNeyfzgNegUq9BrqMjw6IuEXIYIay95pNVjEDKIcXR 0hy81wbLa7zS40ZamOhrCOmVu06VpRel+0BBHU/xxnWiq6FcpIC7hZUDr07Y8GJr 0vmZSO2gX5LuijTITM9KVDJyIxskIPXCYNBvFT3MgXrFhFwe6FvNzXqYib1N/80= =lh45 -----END PGP SIGNATURE----- --Sig_/yf+a1cP3+3l8L_vCwE+Mmay--