Re: [gentoo-dev] evar_push/pop helpers

[Tom Wijsman <TomWij@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Sun, 2 Jun 2013 03:29:33 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> except you aren't handling edge cases (like set vs unset)

You've got me there, though this is quite an exception; I don't see
why we have to introduce something that's barely used...

`qgrep -eH '^\s*\bset\b' | wc -l`
yields 150

`qgrep -eH '^\s*\bset\b' | sed 's/:.*//g' | sed
's/\/[a-zA-Z0-9_.-]*$//g' | sort -u | wc -l`
yields 34

Only 34 packages, and do these all _really_ need a 'set'? I doubt it.

> API 101: implement it once correctly to simplify everyone else.

For set this would make sense, unless someone finds a way to deal with
that too; any Bash experts around here?

> > Much like fixing tiny bug and trying to
> > avoid checking whether anything else is affected.
> 
> yeah, because forcing specific behavior for an entire function is
> always the correct answer.  it's like telling people to export
> LC_ALL=C in make.conf so they never hit locale related problems.

Actually, bug wranglers stopped asked for English build logs because
setting LC_ALL=C ended up breaking things.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]