From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C37F81381F3 for ; Tue, 14 May 2013 14:19:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 48789E08B0; Tue, 14 May 2013 14:19:11 +0000 (UTC) Received: from foo.stuge.se (foo.stuge.se [212.116.89.98]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 12152E0855 for ; Tue, 14 May 2013 14:19:09 +0000 (UTC) Received: (qmail 13712 invoked by uid 501); 14 May 2013 14:19:05 -0000 Message-ID: <20130514141905.13711.qmail@stuge.se> Date: Tue, 14 May 2013 16:19:05 +0200 From: Peter Stuge To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] GitLab Feature-Set / Was: devmanual moved to github Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20879.47550.568189.770408@a1i15.kph.uni-mainz.de> <20130512172003.9979.qmail@stuge.se> <39106330.P4KaKQNKU3@sammi> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Archives-Salt: eb8b3e03-88c8-4401-9168-63a858f87579 X-Archives-Hash: 9ac7f561fe4258c55ea6d842324eb520 Rich Freeman wrote: > Gerrit also requires letting the public push, but those pushes go > to a contained area and each commit is isolated. Hm, how do you mean isolated? Gerrit introduces the convention to create a unique identifier for a change the first time a commit is created. If later iterations of that same logical change (e.g. a second commit after review) keep the Change-Id line from the original commit message then Gerrit knows that this commit is a new version of the old one as opposed to an all new change. Pushing to Gerrit looks and feels like pushing to a git repository but in fact the push goes into Gerrit's own database ("contained area") where it can be reviewed, iterated by pushing again as described above, submitted (output into the project's (readonly) git repo) or rejected. The real beauty of Gerrit is that anything can be accepted into it without affecting the project's real git repo at all, and that only an OpenID is required for pushing. Verification (testing) can be made a requirement before a commit can be submitted in Gerrit, meaning that some test suite needs to pass before a commit can enter the git repo. Some of this can be orchestrated with multiple repositories and lots of hooks, but Gerrit packages it all up quite nicely. While Gerrit is probably most often used as a web application, it's possible to perform most operations, including review, submit and reject, via SSH. The only thing missing from the SSH interface is doing inline review. The web interface allows writing review comments per line in the commit, this is unfortunately not possible via SSH. //Peter