From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9FEDA1381F3 for ; Sat, 27 Apr 2013 15:12:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0D7F9E0C52; Sat, 27 Apr 2013 15:12:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1F32AE097D for ; Sat, 27 Apr 2013 15:12:46 +0000 (UTC) Received: from localhost (178-37-178-225.adsl.inetia.pl [178.37.178.225]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 31B5233DFAE; Sat, 27 Apr 2013 15:12:43 +0000 (UTC) Date: Sat, 27 Apr 2013 17:12:36 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= To: gentoo-dev@lists.gentoo.org Cc: ulm@gentoo.org Subject: Re: [gentoo-dev] [PATCH bash-completion-r1] Introduce get_bashcompdir() to obtain bash-completion dir. Message-ID: <20130427171236.098a541b@gentoo.org> In-Reply-To: <20859.59858.783333.548497@a1i15.kph.uni-mainz.de> References: <1367041504-988-1-git-send-email-mgorny@gentoo.org> <20859.31433.230130.336473@a1i15.kph.uni-mainz.de> <20130427134902.1ba58a4d@gentoo.org> <20859.59858.783333.548497@a1i15.kph.uni-mainz.de> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/Nab2XirctyM+ZNXevD=kNCA"; protocol="application/pgp-signature" X-Archives-Salt: e4151fa1-d1de-4076-8b8a-ef4217c56dc2 X-Archives-Hash: a1ad6b72de9843814edcc95b3e968081 --Sig_/Nab2XirctyM+ZNXevD=kNCA Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable On Sat, 27 Apr 2013 17:08:02 +0200 Ulrich Mueller wrote: > >>>>> On Sat, 27 Apr 2013, Micha=B3 G=F3rny wrote: >=20 > >> > It's better to have a function to obtain that directory rather than = for > >> > ebuilds to hardcode it. > >>=20 > >> Why? >=20 > > For better consistency, I'd say. Especially if we decide to fix Gentoo > > and start using the standard path, we'd need only to modify the eclass > > rather than all involved packages. >=20 > But why should it be a function? Its return value is constant, so > a variable defined in the eclass seems more natural. To be honest, I was thinking the same thing when re-implementing the remaining functions. I can think of two reasons: 1. consistency with other eclasses and functions like get_libdir, 2. possibility of using pkg-config if it becomes necessary. --=20 Best regards, Micha=B3 G=F3rny --Sig_/Nab2XirctyM+ZNXevD=kNCA Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRe+rkXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEK+z4P/R/J0a66rzQyyyyCPraCPm31 rmIo5oOo9FBj+E3cvpIJPD2Cxdot5u/pBXCnIOIvdAgruM0w2FeG8EhSHRw5Ed5I 5oZAjIHxmA1h5XqZ9KtZQ66ugBm0wrMdlfmyZZMIMcJJxPQ8YHtpR+bFBs9lE2VJ 2i6hnJmYCnD0CAsQiYEI2sWzfvgMroV6l6rpCDhCyj/lQlwIFYUD2yTKbicIntME ApvyiYrk3pwcmqHJj0N7iVZC2X4CgCQqRAkOvtlcyPU8VdxDei6Opl4ae+bFJLD2 XRaNbUgimBpaVsYv8nLrbB4Kksr8j8/hnT/CisOexZSNFFtNdn/o2wth1EbZGYQ4 piSYFbiH7G1EXmwfy8NaypkNYgn4w0y83WadnLBW1r09eTtUxaTszf47Ep7Htkb0 0nSZ8SUZmTEgy6etO4crevyyYT0fBXG6q0moGUKB4dsOD/+wb/lHJJ6NczbP+7Yt ZqGuKcK7/Br44OUZZxowsnRoOH4MsqYMme1t6+AIxLyGlzGan+DrgL6Scxu7gdZ+ hhY9csGyRi1XKTKXIxlJQh9iIgqMt8Iybbsv50FpXK2pwGoJoIiyC0mE7OAtq76v u463blEGm3FiYrLC8htsVhLuvj8AIWRkusfm3h/cI4TDlHqrkNe6xMOrFgAd59ft JRLC72EzbJCoAY3mCOQY =0Td5 -----END PGP SIGNATURE----- --Sig_/Nab2XirctyM+ZNXevD=kNCA--