From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AA2B51381F3 for ; Tue, 23 Apr 2013 20:29:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 463EBE09D1; Tue, 23 Apr 2013 20:29:18 +0000 (UTC) Received: from jacques.telenet-ops.be (jacques.telenet-ops.be [195.130.132.50]) by pigeon.gentoo.org (Postfix) with ESMTP id E604FE0991 for ; Tue, 23 Apr 2013 20:29:16 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by jacques.telenet-ops.be with bizsmtp id TYVF1l00r2khLEN0JYVFhk; Tue, 23 Apr 2013 22:29:16 +0200 Date: Tue, 23 Apr 2013 22:27:53 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [OT/NIT] Re: Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask Message-ID: <20130423222753.3854fe4d@TOMWIJ-GENTOO> In-Reply-To: References: <20130419091632.D01152171D@flycatcher.gentoo.org> <20130419153043.30ffc50c@portable> <20130421170549.41cfea49@portable> <20130422154033.65a68a40@portable> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/tjug3B7Ep_M29mGCjmWk01w"; protocol="application/pgp-signature" X-Archives-Salt: 11fec5ce-dba0-4121-b7e5-f65de00d790b X-Archives-Hash: 52c21c229bdbc94c17a91d8a66bd9bb2 --Sig_/tjug3B7Ep_M29mGCjmWk01w Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 22 Apr 2013 22:46:14 +0000 (UTC) Duncan <1i5t5.duncan@cox.net> wrote: > Alexis Ballier posted on Mon, 22 Apr 2013 15:40:33 +0200 as excerpted: >=20 > > "Having functional changes mixed with whitespace/cosmetics in a > > single commit makes it hard to read and understand." > >=20 > >> Also, in this case I see only one extra hunk. > >> But once we have proper tools (like git) we can revisit this. > >=20 > > I don't see how git helps. You'll have to commit twice then push, vs > > commit twice with cvs. >=20 > But git commits are quite lightweight, while as someone already > pointed out, cvs commits, if done properly with repoman, are anything > but. >=20 > So at least in the sense that it'll be less hassle, two git commits=20 > followed by a push should be much easier than two repoman and cvs > commits. >=20 Maybe the question is rather why `repoman` takes 15 seconds on a quite fast system in a package folder that contains 2 ebuilds and 1 metadata. See the call graph for repoman at http://i.imgur.com/OQTUBdR.png. A third of the time, ~5 seconds, are spent on 60,000 - 70,000 calls to the function that is listed in the bottom; but the ebuilds barely list any dependencies. Why are there so much calls to this? A third of the time, ~5 seconds, are spent on visibility; if we look at the `emerge -puDN @world` call graph (http://i.imgur.com/A93CdNR.png) we also see visibility checks taking a prominent enough place. If this is part is really needed, we may look at how we can improve this and at the same time improvement the dependency calculation and repoman times. Last third of the time, ~5 seconds, are spent on regular expressions and mostly configuration; why is configuration so invasive here? My thoughts are that we may be able to shave ten seconds of this time. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/tjug3B7Ep_M29mGCjmWk01w Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJRdu7QAAoJEJWyH81tNOV9mx0H/2pI7tHJf0ta01LSE6PDEBr5 XeivUDh8Pm6uTJkagAGpVvu7T+GflHuA459sX7j71k5bz2jCNqc3LMSyqZu5aSvt NHkj+slJ6QBZNWML9+9qJHxzLoBLpCVaLfX4Wf08hcdEU//2cLKDJfVnj0oGDN0q q8Dh6zJX9BupidiUB/hISVKeX7ea2DWBuhMhqndL8MEp7T3y+9CtSUI4bCznWJn+ h7xigl/LgkMs7QRQ8ziVbRwv8yjzKjDdBmFaOGDbkZnyigv7ltbvHIwBa8EhuFK9 a4zpU64I1GsF1PPeXD3uwWpTDsKUHYtbDr3WbVRjENDuAglWdY4k14/gKMy/oJM= =6Z1n -----END PGP SIGNATURE----- --Sig_/tjug3B7Ep_M29mGCjmWk01w--