From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8D6FC1381F3 for ; Mon, 22 Apr 2013 13:40:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 32903E09F7; Mon, 22 Apr 2013 13:40:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4E4B7E09C2 for ; Mon, 22 Apr 2013 13:40:39 +0000 (UTC) Received: from portable (AMontpellier-651-1-434-83.w92-145.abo.wanadoo.fr [92.145.61.83]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id C19D533DE1B; Mon, 22 Apr 2013 13:40:37 +0000 (UTC) Date: Mon, 22 Apr 2013 15:40:33 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Cc: yngwin@gentoo.org Subject: Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask Message-ID: <20130422154033.65a68a40@portable> In-Reply-To: References: <20130419091632.D01152171D@flycatcher.gentoo.org> <20130419153043.30ffc50c@portable> <20130421170549.41cfea49@portable> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: ed7c9e05-2790-47fa-9296-40327035e3ce X-Archives-Hash: 86c39390c3b274c7a27b0735c3bc2df9 On Mon, 22 Apr 2013 20:00:38 +0800 Ben de Groot wrote: > On 21 April 2013 23:05, Alexis Ballier wrote: > > > On Sun, 21 Apr 2013 20:53:28 +0800 > > Ben de Groot wrote: > > > > > > > > PS: btw, some hunks are weird in your commit, a locale issue ? > > > > > > > > > > No, just a line in my vimrc that removes trailing whitespace. > > > > > > > You should probably disable it or remove trailing whitespaces in a > > separate commit though. Having functional changes mixed with > > whitespace/cosmetics in a single commit makes it hard to read > > and understand. > > > > [This is really a nitpick, no need to have a debate, it's only a > > suggestion ;)] > > > > Alexis. > > > > I don't see the problem. "Having functional changes mixed with whitespace/cosmetics in a single commit makes it hard to read and understand." > Also, in this case I see only one extra hunk. > But once we have proper tools (like git) we can revisit this. I don't see how git helps. You'll have to commit twice then push, vs commit twice with cvs. > I don't think there is currently any guideline in devmanual that > recommends not mixing functional changes with cosmetics. I was pretty sure there was one but can't find it anymore. Anyway, I don't think there needs to be any rule for this, it is common sense. Alexis.