On Sun, 21 Apr 2013 17:05:49 +0200
Alexis Ballier <aballier@gentoo.org> wrote:

> On Sun, 21 Apr 2013 20:53:28 +0800
> Ben de Groot <yngwin@gentoo.org> wrote:
> > >
> > > PS: btw, some hunks are weird in your commit, a locale issue ?
> > >
> > 
> > No, just a line in my vimrc that removes trailing whitespace.
> 
> You should probably disable it or remove trailing whitespaces in a
> separate commit though. Having functional changes mixed with
> whitespace/cosmetics in a single commit makes it hard to read
> and understand.

While I'm usually strongly for that, I would just like to point out
that we're using CVS and 'repoman commit', and these two together make
committing a really painful and time-consuming experience. I can see
the benefit of avoiding a second commit just to fix whitespace.

-- 
Best regards,
Michał Górny