From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B301D1381F3 for ; Sun, 21 Apr 2013 17:08:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3E97AE0929; Sun, 21 Apr 2013 17:08:29 +0000 (UTC) Received: from jacques.telenet-ops.be (jacques.telenet-ops.be [195.130.132.50]) by pigeon.gentoo.org (Postfix) with ESMTP id 121F5E08A5 for ; Sun, 21 Apr 2013 17:08:27 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by jacques.telenet-ops.be with bizsmtp id Sh8S1l00p2khLEN0Jh8TxM; Sun, 21 Apr 2013 19:08:27 +0200 Date: Sun, 21 Apr 2013 19:07:09 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask Message-ID: <20130421190709.105e02ae@TOMWIJ-GENTOO> In-Reply-To: <20130421160042.3881.qmail@stuge.se> References: <20130419091632.D01152171D@flycatcher.gentoo.org> <20130419153043.30ffc50c@portable> <20130421170549.41cfea49@portable> <20130421173226.2901a6fd@TOMWIJ-GENTOO> <20130421160042.3881.qmail@stuge.se> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/xR7Xb3+xticY.YL+nTuIAIs"; protocol="application/pgp-signature" X-Archives-Salt: 636e6bff-673c-4761-aac7-1cacc861ffde X-Archives-Hash: 510d591395b2fa6bbec3879efeaf1036 --Sig_/xR7Xb3+xticY.YL+nTuIAIs Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 21 Apr 2013 18:00:42 +0200 Peter Stuge wrote: > > You should just convert the commit diff to not include space > > changes. >=20 > Tom, I don't understand what you mean here? Who should do the convert > and why? It's a human error for both ends, it can thus be done on both sides. > Writing good code takes experience and awareness, and many if not > most are just interested in banging out something that works. Good code ideally is tested. > ... minimize the impact, and the best way is to ... Depends on whose impact you minimize, s/best/alternative/. > Specifically, interactive rebase on its own or combined with > bisecting become a lot easier and quicker with clean commits. Rebasing is overkill in the Portage tree and not needed; as for bisect, it makes it worse because you introduce extra commits to bisect. > Try not to be that person, because it doesn't help anyone. I'm not rooting either side, I just hate the noise that occurs when neither side takes an effort to fix it. I can tell from a private mail from one of the persons that at least one side is interested, I'm not so sure about the other side; but well, better than an endless debate. > If something becomes easier by using a particular process or > workflow, then I think that's a good reason to do it. And that's why I responded, I won't respond any further to this thread. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/xR7Xb3+xticY.YL+nTuIAIs Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJRdBzBAAoJEJWyH81tNOV90qAIAMB/HDT+HlWoxLLLrPK73HhG gfNdum7dSdZqvU0ZIwx9atZWfaxi9pDpbvI5Za/T0NrDRoHxTM0fBwkxropcS4LV 7Mh7tyeBNHUV5Noy/CiWFEkk6qrf98eYuavfAJihT7DfnPoR5JmYW+YY+ipmoxWO 7+S0HW3Ut5tbwDvX6IV7Pb+SLe+M3SGHzeV0FwoYT3jVMJDmjGP9qvJUuxANLgFL t5kx8F0DDNlyzGEL0XRAKSzvypSsHIFias5JeRtPJmp9P++0TLN3C3DaUYDqstxY gMtKWb9yXyfJ6XFl7XeEUCEwHrUARfSrSZQCBuHFEzAmQ9SHZxA1+mvskfXjCrk= =DbV7 -----END PGP SIGNATURE----- --Sig_/xR7Xb3+xticY.YL+nTuIAIs--