Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask

[Tom Wijsman <TomWij@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]

On Sun, 21 Apr 2013 18:00:42 +0200
Peter Stuge <peter@stuge.se> wrote:

> > You should just convert the commit diff to not include space
> > changes.
> 
> Tom, I don't understand what you mean here? Who should do the convert
> and why?

It's a human error for both ends, it can thus be done on both sides.

> Writing good code takes experience and awareness, and many if not
> most are just interested in banging out something that works.

Good code ideally is tested.

> ... minimize the impact, and the best way is to ...

Depends on whose impact you minimize, s/best/alternative/.

> Specifically, interactive rebase on its own or combined with
> bisecting become a lot easier and quicker with clean commits.

Rebasing is overkill in the Portage tree and not needed; as for bisect,
it makes it worse because you introduce extra commits to bisect.

> Try not to be that person, because it doesn't help anyone.

I'm not rooting either side, I just hate the noise that occurs when
neither side takes an effort to fix it. I can tell from a private mail
from one of the persons that at least one side is interested, I'm not
so sure about the other side; but well, better than an endless debate.

> If something becomes easier by using a particular process or
> workflow, then I think that's a good reason to do it.

And that's why I responded, I won't respond any further to this thread.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]