From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: TomWij@gentoo.org
Subject: Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask
Date: Sun, 21 Apr 2013 17:43:51 +0200 [thread overview]
Message-ID: <20130421174351.06697797@portable> (raw)
In-Reply-To: <20130421173226.2901a6fd@TOMWIJ-GENTOO>
On Sun, 21 Apr 2013 17:32:26 +0200
Tom Wijsman <TomWij@gentoo.org> wrote:
> On Sun, 21 Apr 2013 17:05:49 +0200
> Alexis Ballier <aballier@gentoo.org> wrote:
>
> > On Sun, 21 Apr 2013 20:53:28 +0800
> > Ben de Groot <yngwin@gentoo.org> wrote:
> > > >
> > > > PS: btw, some hunks are weird in your commit, a locale issue ?
> > > >
> > >
> > > No, just a line in my vimrc that removes trailing whitespace.
> > >
> >
> > You should probably disable it or remove trailing whitespaces in a
> > separate commit though. Having functional changes mixed with
> > whitespace/cosmetics in a single commit makes it hard to read
> > and understand.
>
> You should just convert the commit diff to not include space changes.
How? Sometimes space changes matter a lot...
Alexis.
next prev parent reply other threads:[~2013-04-21 15:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130419091632.D01152171D@flycatcher.gentoo.org>
2013-04-19 13:30 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask Alexis Ballier
2013-04-20 17:28 ` Jeroen Roovers
2013-04-21 12:53 ` Ben de Groot
2013-04-21 14:11 ` Denis Dupeyron
2013-04-21 14:23 ` Rich Freeman
2013-04-21 14:39 ` Denis Dupeyron
2013-04-21 14:38 ` Chí-Thanh Christopher Nguyễn
2013-04-21 14:50 ` Denis Dupeyron
2013-04-21 15:07 ` Chí-Thanh Christopher Nguyễn
2013-04-21 15:17 ` Alexis Ballier
2013-04-22 11:43 ` Ben de Groot
2013-04-22 17:13 ` Michał Górny
2013-04-23 16:16 ` Ben de Groot
2013-04-22 12:07 ` Ben de Groot
2013-04-21 14:59 ` Alexis Ballier
2013-04-22 11:56 ` Ben de Groot
2013-04-22 14:00 ` Alexis Ballier
2013-04-23 3:58 ` Ryan Hill
2013-04-23 16:24 ` Ben de Groot
2013-04-24 10:59 ` Duncan
2013-04-30 2:06 ` Ryan Hill
2013-04-21 15:05 ` [OT/NIT] " Alexis Ballier
2013-04-21 15:32 ` Tom Wijsman
2013-04-21 15:43 ` Alexis Ballier [this message]
2013-04-21 16:00 ` Peter Stuge
2013-04-21 17:07 ` Tom Wijsman
2013-04-21 18:47 ` Peter Stuge
2013-04-21 18:57 ` Michał Górny
2013-04-22 12:00 ` Ben de Groot
2013-04-22 13:40 ` Alexis Ballier
2013-04-22 22:46 ` [gentoo-dev] Re: [OT/NIT] " Duncan
2013-04-23 18:00 ` Jeroen Roovers
2013-04-23 18:20 ` Rich Freeman
2013-04-23 18:37 ` Matt Turner
2013-04-23 19:11 ` Rich Freeman
2013-04-23 19:21 ` Matt Turner
2013-04-23 19:25 ` Ian Stakenvicius
2013-04-23 19:43 ` Rich Freeman
2013-04-23 18:38 ` Matt Turner
2013-04-24 11:18 ` Duncan
2013-04-24 11:21 ` Peter Stuge
2013-04-24 11:25 ` Peter Stuge
2013-04-24 11:47 ` Michael Mol
2013-04-24 13:25 ` Rich Freeman
2013-04-24 20:04 ` Alex Xu
2013-04-24 22:26 ` Rich Freeman
2013-04-24 23:23 ` Patrick Lauer
2013-04-24 23:50 ` Peter Stuge
2013-04-23 19:31 ` Michał Górny
2013-04-23 19:50 ` Jeroen Roovers
2013-04-23 20:27 ` Tom Wijsman
2013-04-23 21:12 ` Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421174351.06697797@portable \
--to=aballier@gentoo.org \
--cc=TomWij@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox