From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id EB1101381F3 for ; Sun, 21 Apr 2013 15:33:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9947AE09D6; Sun, 21 Apr 2013 15:33:48 +0000 (UTC) Received: from juliette.telenet-ops.be (juliette.telenet-ops.be [195.130.137.74]) by pigeon.gentoo.org (Postfix) with ESMTP id 70978E09B4 for ; Sun, 21 Apr 2013 15:33:47 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by juliette.telenet-ops.be with bizsmtp id SfZm1l00N2khLEN06fZmd6; Sun, 21 Apr 2013 17:33:46 +0200 Date: Sun, 21 Apr 2013 17:32:26 +0200 From: Tom Wijsman To: gentoo-dev@lists.gentoo.org Subject: Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask Message-ID: <20130421173226.2901a6fd@TOMWIJ-GENTOO> In-Reply-To: <20130421170549.41cfea49@portable> References: <20130419091632.D01152171D@flycatcher.gentoo.org> <20130419153043.30ffc50c@portable> <20130421170549.41cfea49@portable> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/WGImd03eeqSqk6hW3/36Hod"; protocol="application/pgp-signature" X-Archives-Salt: 8508a64b-0309-4a27-b8d7-4c0c9c51275c X-Archives-Hash: f352f10d27c8bbd4b9c2c35eff1397b5 --Sig_/WGImd03eeqSqk6hW3/36Hod Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 21 Apr 2013 17:05:49 +0200 Alexis Ballier wrote: > On Sun, 21 Apr 2013 20:53:28 +0800 > Ben de Groot wrote: > > > > > > PS: btw, some hunks are weird in your commit, a locale issue ? > > > > >=20 > > No, just a line in my vimrc that removes trailing whitespace. > >=20 >=20 > You should probably disable it or remove trailing whitespaces in a > separate commit though. Having functional changes mixed with > whitespace/cosmetics in a single commit makes it hard to read > and understand. You should just convert the commit diff to not include space changes. > [This is really a nitpick, no need to have a debate, it's only a > suggestion ;)] [There are two sides to a debate; so, the nitpick goes both ways. ;)] --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/WGImd03eeqSqk6hW3/36Hod Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJRdAaRAAoJEJWyH81tNOV9PHMH/2WCSJvMG7BBYr9g39YMhCba btXEhTj9TzjI9GjS/msz92QPh68ySx80DpVy+Rq4tr1cq1e4jKr1jePugv6+JhtQ DdJCdMHfBZagFb96Z+5FAC1pxngWNj6SyzbedGV9q+E9ZsdUXkmgYa+MX3PAX+CB bundEd0n/OxQFMQM42eEP5GmDVGyrg2+UwJL9aJpDJs8n7ttl9Jf32fJKs1VL1LC Ui0J5T8JCkp0PNKkMkeiyHOj9DxOIlTmNJDA+g4I7jHw9jrBmr1O2h7dRIusfSVg whZrj2EmuziZ1SOad4u9ZhAMXVH+Fxu602ad3hkJjQNk55E1FRx/EZK4TZFTVhk= =rezq -----END PGP SIGNATURE----- --Sig_/WGImd03eeqSqk6hW3/36Hod--