From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-59744-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 98BC81381F3
	for <garchives@archives.gentoo.org>; Sun, 21 Apr 2013 15:06:04 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 8EDD5E0B61;
	Sun, 21 Apr 2013 15:05:56 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id A6D84E091F
	for <gentoo-dev@lists.gentoo.org>; Sun, 21 Apr 2013 15:05:55 +0000 (UTC)
Received: from portable (AMontpellier-651-1-434-83.w92-145.abo.wanadoo.fr [92.145.61.83])
	(using SSLv3 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: aballier)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 1B41333DEF3;
	Sun, 21 Apr 2013 15:05:53 +0000 (UTC)
Date: Sun, 21 Apr 2013 17:05:49 +0200
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: yngwin@gentoo.org
Subject: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in
 profiles: ChangeLog package.mask
Message-ID: <20130421170549.41cfea49@portable>
In-Reply-To: <CAB9SyzRq-RuMUU0cXnWYC_+-yv3FSJ=fDw335QmUrqQinsbzQw@mail.gmail.com>
References: <20130419091632.D01152171D@flycatcher.gentoo.org>
	<20130419153043.30ffc50c@portable>
	<CAB9SyzRq-RuMUU0cXnWYC_+-yv3FSJ=fDw335QmUrqQinsbzQw@mail.gmail.com>
Organization: Gentoo
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 98cad52a-18ee-4ffd-80ec-4101fa8bf579
X-Archives-Hash: 382611c24c2affab27ca9ea4d2c84d4a

On Sun, 21 Apr 2013 20:53:28 +0800
Ben de Groot <yngwin@gentoo.org> wrote:
> >
> > PS: btw, some hunks are weird in your commit, a locale issue ?
> >
> 
> No, just a line in my vimrc that removes trailing whitespace.
> 

You should probably disable it or remove trailing whitespaces in a
separate commit though. Having functional changes mixed with
whitespace/cosmetics in a single commit makes it hard to read
and understand.

[This is really a nitpick, no need to have a debate, it's only a
suggestion ;)]

Alexis.