From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E04CD1381F3 for ; Wed, 17 Apr 2013 18:28:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 24C2DE0B40; Wed, 17 Apr 2013 18:28:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 244F9E0B3D for ; Wed, 17 Apr 2013 18:28:06 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 3966933DE51 for ; Wed, 17 Apr 2013 18:28:05 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH eutils] Support recursive operation in edos2unix. Date: Wed, 17 Apr 2013 14:30:11 -0400 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) References: <1365864260-1606-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1365864260-1606-1-git-send-email-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart20406510.Xo3WHtxELQ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201304171430.12608.vapier@gentoo.org> X-Archives-Salt: c81246a3-8761-4277-9ea1-c2cf4845b5fb X-Archives-Hash: 721bebef797505246694f48109c5374f --nextPart20406510.Xo3WHtxELQ Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 13 April 2013 10:44:20 Micha=C5=82 G=C3=B3rny wrote: > The edos2unix is quite useful when handling DOS-sourced packages. > But since it's a bash function, you can't reasonably use it from within > find invocation. And often you hit packages which are all flooded with > CRLFs that you need to convert. >=20 > That's why I'm suggesting to make edos2unix recursive. The posted patch > changes the function to use find+sed for the substitution, passing given > paths as the 'path' arguments to find. >=20 > Whenever files are passed, nothing changes for ebuilds. If a directory > is passed, find converts it recursively. The only potential breakage is > when a non-file was passed and something weird was expected of it. i'm ambivalent on requiring the -r flag, so this LGTM as is =2Dmike --nextPart20406510.Xo3WHtxELQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRbuo0AAoJEEFjO5/oN/WBPuMQAMHS92sG/WWAYOSbLe6/Prh/ VerePlVsyBnePHlaz7X+rBUxcFLh/QpXUhRq7ZpK20EQOO5q7KivDDFfIdku+Wrd 8lAG7WfuJP9nVe6GO/kMU8yZUVEhhoceEMGBVv4JQ5/25K4cPAgrp58HYDurPwUf AGq29zV/gBavNSu485kHUQqkkXboQLdhqmsQHko8+pDR0Dh9lm+MU6EYO0i7g1N/ gQu3EEvomz4xFIav3Nm0HGEyZwLR59GfibluAzND6LQTNVBwypI5+7h+F9h0Kgqn PDQUwSZnSFwLGwjgVEc4GXbgo0YdwLmDl1LRETt8jDpz7nivNWMw1+MgrI1GFsmH XDjkyE1rM4xSWOQY6M9NKbnknGEQhom/MSaAKTa8njzYXSugaDCtt8i4P+n3xa6p veYgO+UmJRMkxj6Cpj3i274O8sBclZrIprRwWzkGgL+/7SodC7QID65Ei4g2lGwl q8Qnh8YkXSfmQKl2lnQfPynUsPydYGElpJ8squJRbPQoWQlzJcu54jr26RA74TVU 2W0DMUBts8C1kjMdWqCRKSs1UqCZdXU6jC1cltt849HGMz/NulxCBqJg9T60eTnt VtG6BVjSWvbJT1GV7vz//ZvqvOaLmA73mJzEi+GXGIowHwwZwUXFi0lk3r3MAChb 8c6UiJWX8g5DXkb7OHmH =0SGH -----END PGP SIGNATURE----- --nextPart20406510.Xo3WHtxELQ--