public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Steven J. Long" <slong@rathaus.eclipse.co.uk>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: [RFC] Cleaning up PMS to have ${D} not end with a slash
Date: Mon, 15 Apr 2013 18:31:32 +0100	[thread overview]
Message-ID: <20130415173132.GA1698@rathaus.eclipse.co.uk> (raw)
In-Reply-To: <20130415120124.317cb7d3@googlemail.com>

On Mon, Apr 15, 2013 at 12:01:24PM +0100, Ciaran McCreesh wrote:
> On Mon, 15 Apr 2013 10:56:45 +0000
> "Aaron W. Swenson" <titanofold@gentoo.org> wrote:
> > ROOT being a user set variable, having ROOT be an empty string by
> > default still does not guarantee that ROOT won't end with a
> > slash. Even if we change it so that it defaults to an empty string, it
> > won't negate the need to do ${ROOT%/}/some/path.
> 
> The spec guarantees that ROOT will be non-empty and end in a slash. If
> Portage isn't enforcing this, file a bug.

Yes, but his point was this:

> > The only thing that would help is if PMS defined that ROOT must not
> > end with a slash.
 
ie, let the mangler enforce empty or a valid directory not ending in a
slash, which is hardly difficult, and makes ROOT easier to work with,
along the lines of how any shellscripter would do it, similarly to the
motivation for the change to D. Only with ROOT it's much more important
that the path is correctly-formed for cross-platform compatibility.

-- 
#friendly-coders -- We're friendly, but we're not /that/ friendly ;-)


  reply	other threads:[~2013-04-15 17:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 21:23 [gentoo-dev] [RFC] Cleaning up PMS to have ${D} not end with a slash Michał Górny
2013-04-14  8:31 ` Gregory M. Turner
2013-04-14 10:24 ` Peter Stuge
2013-04-14 11:32 ` Michał Górny
2013-04-14 11:34   ` Michał Górny
2013-04-14 14:14 ` hasufell
2013-04-14 15:01   ` Michał Górny
2013-04-14 14:22 ` Ciaran McCreesh
2013-04-14 14:58   ` Michał Górny
2013-04-14 16:39     ` Ciaran McCreesh
2013-04-14 16:59       ` Michał Górny
2013-04-15 10:56         ` Aaron W. Swenson
2013-04-15 11:01           ` Ciaran McCreesh
2013-04-15 17:31             ` Steven J. Long [this message]
2013-04-15 18:54               ` [gentoo-dev] " Gregory M. Turner
2013-04-18 23:02                 ` [gentoo-dev] " Steven J. Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415173132.GA1698@rathaus.eclipse.co.uk \
    --to=slong@rathaus.eclipse.co.uk \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox