Re: [gentoo-dev] [RFC] Cleaning up PMS to have ${D} not end with a slash

["Aaron W. Swenson" <titanofold@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]

On Sun, Apr 14, 2013 at 06:59:19PM +0200, Michał Górny wrote:
> On Sun, 14 Apr 2013 17:39:44 +0100
> Ciaran McCreesh <ciaran.mccreesh@googlemail.com> wrote:
> 
> > On Sun, 14 Apr 2013 16:58:07 +0200
> > Michał Górny <mgorny@gentoo.org> wrote:
> > > On Sun, 14 Apr 2013 15:22:42 +0100
> > > Ciaran McCreesh <ciaran.mccreesh@googlemail.com> wrote:
> > > > On Sat, 13 Apr 2013 23:23:57 +0200
> > > > Michał Górny <mgorny@gentoo.org> wrote:
> > > > Should ROOT usually be empty then?
> > > 
> > > Considering its use, probably yes.
> > > 
> > >   ${ROOT}/usr/bin/foo
> > >   ${EPREFIX}/usr/bin/foo
> > >   ${D}${EPREFIX}/usr/bin/foo
> > > 
> > > All seem clean and consistent to me.
> > 
> > How many things test whether ROOT=/ ? I seem to recall that being
> > fairly common, back when something accidentally set it to //.
> 
> Yes, that sucks a fair bit. There are many ebuilds doing that, and most
> of those ebuilds append additional slash after it anyway... we really
> suck at consistency.
> 

We're only accountable insofar as ROOT defaults to "/".

ROOT being a user set variable, having ROOT be an empty string by
default still does not guarantee that ROOT won't end with a
slash. Even if we change it so that it defaults to an empty string, it
won't negate the need to do ${ROOT%/}/some/path.

The only thing that would help is if PMS defined that ROOT must not
end with a slash. In which case it would be up to the package manage
to modify ROOT before it gets evaluated in an ebuild.

-- 
Mr. Aaron W. Swenson
Gentoo Linux Developer
Email : titanofold@gentoo.org
GnuPG FP : 2C00 7719 4F85 FB07 A49C 0E31 5713 AA03 D1BB FDA0
GnuPG ID : D1BBFDA0

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]