public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ciaran.mccreesh@googlemail.com
Subject: Re: [gentoo-dev] [RFC] Cleaning up PMS to have ${D} not end with a slash
Date: Sun, 14 Apr 2013 18:59:19 +0200	[thread overview]
Message-ID: <20130414185919.5c9d8632@pomiocik.lan> (raw)
In-Reply-To: <20130414173944.40e13591@googlemail.com>

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

On Sun, 14 Apr 2013 17:39:44 +0100
Ciaran McCreesh <ciaran.mccreesh@googlemail.com> wrote:

> On Sun, 14 Apr 2013 16:58:07 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
> > On Sun, 14 Apr 2013 15:22:42 +0100
> > Ciaran McCreesh <ciaran.mccreesh@googlemail.com> wrote:
> > > On Sat, 13 Apr 2013 23:23:57 +0200
> > > Michał Górny <mgorny@gentoo.org> wrote:
> > > > As most of you probably doesn't know, PMS guarantees that ${D}
> > > > always ends with a slash. It seems that this particular wording
> > > > was enforced by historical portage behavior (instead of fixing
> > > > the ebuilds...) yet it didn't ever get really widespread.
> > > 
> > > Should ROOT usually be empty then?
> > 
> > Considering its use, probably yes.
> > 
> >   ${ROOT}/usr/bin/foo
> >   ${EPREFIX}/usr/bin/foo
> >   ${D}${EPREFIX}/usr/bin/foo
> > 
> > All seem clean and consistent to me.
> 
> How many things test whether ROOT=/ ? I seem to recall that being
> fairly common, back when something accidentally set it to //.

Yes, that sucks a fair bit. There are many ebuilds doing that, and most
of those ebuilds append additional slash after it anyway... we really
suck at consistency.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

  reply	other threads:[~2013-04-14 16:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 21:23 [gentoo-dev] [RFC] Cleaning up PMS to have ${D} not end with a slash Michał Górny
2013-04-14  8:31 ` Gregory M. Turner
2013-04-14 10:24 ` Peter Stuge
2013-04-14 11:32 ` Michał Górny
2013-04-14 11:34   ` Michał Górny
2013-04-14 14:14 ` hasufell
2013-04-14 15:01   ` Michał Górny
2013-04-14 14:22 ` Ciaran McCreesh
2013-04-14 14:58   ` Michał Górny
2013-04-14 16:39     ` Ciaran McCreesh
2013-04-14 16:59       ` Michał Górny [this message]
2013-04-15 10:56         ` Aaron W. Swenson
2013-04-15 11:01           ` Ciaran McCreesh
2013-04-15 17:31             ` [gentoo-dev] " Steven J. Long
2013-04-15 18:54               ` Gregory M. Turner
2013-04-18 23:02                 ` [gentoo-dev] " Steven J. Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130414185919.5c9d8632@pomiocik.lan \
    --to=mgorny@gentoo.org \
    --cc=ciaran.mccreesh@googlemail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox