From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C57BB1381F3 for ; Sat, 13 Apr 2013 15:35:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6F760E09CC; Sat, 13 Apr 2013 15:35:12 +0000 (UTC) Received: from smtpout.karoo.kcom.com (smtpout.karoo.kcom.com [212.50.160.34]) by pigeon.gentoo.org (Postfix) with ESMTP id 6C1F8E09B3 for ; Sat, 13 Apr 2013 15:35:11 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.87,468,1363132800"; d="scan'208";a="9057890" Received: from unknown (HELO rathaus.eclipse.co.uk) ([91.85.37.233]) by smtpout.karoo.kcom.com with ESMTP; 13 Apr 2013 16:34:52 +0100 Date: Sat, 13 Apr 2013 17:00:54 +0100 From: "Steven J. Long" To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: Pass "${@}" in phase functions Re: [PATCH] Introduce cmake-multilib wrapper for cmake-utils. Message-ID: <20130413160054.GA15547@rathaus.eclipse.co.uk> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20130206105605.32b55a8d@pomiocik.lan> <1360144960-1327-1-git-send-email-mgorny@gentoo.org> <5168AF33.2020707@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5168AF33.2020707@gentoo.org> X-Archives-Salt: cd346065-0e3d-4171-bceb-10dcc8200ee9 X-Archives-Hash: 960a2109d3663ae5aa38c43b696cad58 On Sat, Apr 13, 2013 at 03:04:51AM +0200, Michael Weber wrote: > I'm not sure if it's a sane way to push make -j1 via > > src_compile() { > cmake-multilib_src_compile -j1 > } > > but I detected a lack of functionality in the current > cmake-multilib.eclass. Both cmake-utils.eclass and multilib-build.eclass > have it, so it might be sound to continue with this behavior. > > Comments, pls. I can't speak to the cmake bit, but passing "$@" makes a lot of sense, and puts the decision in the hands of the ebuild author, where it belongs. -- #friendly-coders -- We're friendly, but we're not /that/ friendly ;-)