From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B17AD1381F3 for ; Sat, 6 Apr 2013 21:41:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1C957E0935; Sat, 6 Apr 2013 21:41:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0F105E0921 for ; Sat, 6 Apr 2013 21:41:16 +0000 (UTC) Received: from pomiocik.lan (77-253-156-83.adsl.inetia.pl [77.253.156.83]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 0F3EE33DD99; Sat, 6 Apr 2013 21:41:14 +0000 (UTC) Date: Sat, 6 Apr 2013 23:41:33 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: phajdan.jr@gentoo.org Subject: Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean Message-ID: <20130406234133.4d9227e9@pomiocik.lan> In-Reply-To: <51607EE3.1050005@gentoo.org> References: <20130406200843.6831c4fe@pomiocik.lan> <51607144.5040003@gentoo.org> <20130406214127.52b4b500@pomiocik.lan> <51607EE3.1050005@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/mp_=/PKP1I+i=Qf.jB0ReHU"; protocol="application/pgp-signature" X-Archives-Salt: 3b1f9fff-4bd0-4e19-a48f-57d39a0a67b5 X-Archives-Hash: e7182b7c52b4611b3678597e790f26ad --Sig_/mp_=/PKP1I+i=Qf.jB0ReHU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 06 Apr 2013 13:00:35 -0700 ""Pawe=C5=82 Hajdan, Jr."" wrote: > On 4/6/13 12:41 PM, Micha=C5=82 G=C3=B3rny wrote: > > I would honestly just go for the git style. It's the first thing that > > really succeeded in standardizing patches. Inventing something new is > > not really necessary, I believe. >=20 > Oh, I didn't mean inventing anything new. >=20 > Is there some URL or documentation I could read to familiarize myself > with all of the "git style"? Hmm, it seems that there is nothing really common, just various things that were used and started to be expected by random tools. Except for bits of notes in git manpages, there's some info in the 'submitting patches' doc [1]. The general idea is similar to the e-mail concept. Shortly saying, it's: One line of topic Paragraph of text, usually wrapped at 72 chars....................... Second line of the same paragraph, etcetera. Second paragraph. Then we'll have a list: - item 1 - item 2 Some-tags: ... Other-tag: ... (indent added to mail to make it clear, no indent in patch file :)) Although git itself rather preserves newlines, some tool concatenate successive lines, so you separate paragraphs (and items) with empty lines. First paragraph (some tools may read one line only!) goes as a short summary, that is shown in 'git log --oneline'. The following paragraphs (optional) should explain better what's happening. Optionally, after the last paragraph you can add a few lines with tags in form of 'Tag: value'. AFAICS git itself uses only 'Signed-off-by' but you can find more tags in various 'submitting patches' docs. 'Signed-off-by' lists the one responsible for the patch. Some upstreams require that line, some take over authorship of patches if you don't add it (like X.org), some just hate it :). The X.org wiki lists also 'Fixes' for bugtracker URL [2] and a few tags for reviewing patches [3] (those are probably not useful for us). Some upstreams also use different bugtracker tag formats [4,5] but I feel like they're not proper for our patches since they don't mention the bugtracker URI. That said, I'd probably ping them about it. [1]:http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPat= ches [2]:http://www.x.org/wiki/Development/Documentation/SubmittingPatches#Commi= t_message_format [3]:http://www.x.org/wiki/Development/Documentation/SubmittingPatches#Signi= ng_off_and_reviewing [4]:http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [5]:https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_re= ferences --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/mp_=/PKP1I+i=Qf.jB0ReHU Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRYJaNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKAMQP/0+EM/+KHO+7m0HhaJqYl0YQ 5rUPZxJk7farQ7+ZU0qQymTQ80/jIx0kAQqjUmF95nP8TeLW6uHYG6oivGFan5FE oMSuhZrwjFTTQO2clWvgPvwP+7UqTWVMK1Co5GNH+3A1cAdS0+ZYJQZ/D41CCubQ yyA+BmIbf+eI93B3ckWrN1nudCoIOyUPVI6ZnS98FAWQbpvmnQJivHsnWxJl2zbQ 4iQy6v8wUTpUJ9t3Ohmwi6WeX4uT4fqB/K5iDUvPaWo8pZ6wGw5h0EI3iCP+Nz5Z CnTXtlj6togWdLm0cVDm9k/0mfKL7hwxlGNBhKGb2bFwgyZY4WzPd8oSwg4xCmp0 0aoSFZgZiw/t09M93mHPAsujyV4BxxOWr0+HSBU7Q8Tzsj9JrkWjrSsgzvW/s8Y+ DrI0x1nT1okd2Miou3I9V9tN3XXh/c1WLeVdcdztFTpe1Y8xMPOdSQvA56bfSk1h mer5AIlIPBvO+d07op0CrgJBvjM4aoqZyczvXPcEB89DT/liCU/wNCnS/IHpnYib sSLXELmwcarrL8xaH0seBYEeQUmQAtzIHZw5pIVmiEJS40TlNhes0sWTyI7HmlFQ u1U8Kp5sAggGS6UDLg+DDZ/wjIjhr16iewYsg9DRWhazvOubrdJ19YxTcSAw9eks APGev/kIxdLrIr1GWCYZ =AajU -----END PGP SIGNATURE----- --Sig_/mp_=/PKP1I+i=Qf.jB0ReHU--