From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 83FD51381F3 for ; Sat, 6 Apr 2013 18:59:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E126BE0762; Sat, 6 Apr 2013 18:59:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E5206E073C for ; Sat, 6 Apr 2013 18:59:19 +0000 (UTC) Received: from pomiocik.lan (77-253-156-83.adsl.inetia.pl [77.253.156.83]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 660B933DC08; Sat, 6 Apr 2013 18:59:17 +0000 (UTC) Date: Sat, 6 Apr 2013 20:59:59 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: tetromino@gentoo.org Subject: Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean Message-ID: <20130406205959.25b2b4c7@pomiocik.lan> In-Reply-To: <1365273347.9078.9.camel@rook> References: <20130406200843.6831c4fe@pomiocik.lan> <1365273347.9078.9.camel@rook> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_//T7OkldbUhQ_MX6_kX_RsXR"; protocol="application/pgp-signature" X-Archives-Salt: 5a83d09a-c1a0-48e1-801d-bacfd8d3e4bb X-Archives-Hash: 604c6a8d9fb635b766add9591303ec2c --Sig_//T7OkldbUhQ_MX6_kX_RsXR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 06 Apr 2013 14:35:47 -0400 Alexandre Rostovtsev wrote: > On Sat, 2013-04-06 at 20:08 +0200, Micha=C5=82 G=C3=B3rny wrote: > > 2. Patches have to apply to the top directory of the source tree with > > 'patch -p1'. If patches are applied to sub-directories, necessary '-p' > > argument shall be passed to 'epatch' explicitly. Developers are > > encouraged to create patches which are compatible with 'git am'. >=20 > Please don't make -p1 into a hard requirement :/ >=20 > There are upstreams who have different directory layouts in their scm > tree and in their source tarballs. If I clone an upstream git repository > to obtain a patch or to write a new patch that I will submit upstream, I > want to be able to apply that patch in an ebuild without having to > manually sed it to change the -p level. You will need to supply '-p2' in the *worst* case. > Specific examples of this among packages that I maintain: app-cdr/cdemu, > app-cdr/cdemu-daemon, sys-fs/vhba. These all use the same git tree, and > source tarballs for individual packages are created from different > subdirectories of that git tree. In the context of the entry, 'top directory' would mean the common git root. So the patches suitable for 'git am' on that repo will be correct. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_//T7OkldbUhQ_MX6_kX_RsXR Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRYHCvXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKDuIQAO9PWq/X4IDiSr5819Jo8Y3H xHpc6Ml/jDgui82Zcbh6Q6lCbiJ6Kl8MB3uI6NcNQJCauCowjjFkqbqAyfNg+Wcs LNEqEWtytbXlcNVfOioxDeZRdBW8+5vVOWsKliCUULfZd2qG+mhgibxiYaex2bOM DJfAUbc2eHGqxxOQnEVrgCPxzPWxJuSwGK2LLMTn134FkyDeEd0FGfhyntI+Ebdr E5akf1lW2iR5sm39YCVnGhMeRWKw2BMvQt8xZgAxX3muceuSMgEZZFd3hZnx0WNz xyCv5MXpWhDFOgUiWE796GcBUGqV/L499kW9kAWj88HExzoYdgLyxd88DCvRkbTY gei5ZObOef4F27fSyHLucoy1bpxYePpdI7aFYsxGjwEAwyr3nXHOXmnrIYxnrG6A Qs+1BEfn1A75tHH+uyQ4LCofhJKyzvWW84xoi+c/ywCxdMDOLolCIqGJflHjbOTw TBskrMjo6te92iZqd0z47a82+JGjDo3Taq6qfzlXUMncqU0JKQ/AP+PQ4UQD874r n8XDkDzHqP8Hp1v5r3Bjbau3sO1Olby/SfTSMkc3C84jw5K3WcsG64TUFkq0FmF/ WILD3R/Itqea7yY1/Mwz4IPj/XbLOzvZ/HnYiChN3FpnS+oq8Z0W9aGnK1LFbN4x KFCbU5CTtR2E8YeziTnR =zo4h -----END PGP SIGNATURE----- --Sig_//T7OkldbUhQ_MX6_kX_RsXR--