From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BFFB71381F3 for ; Thu, 4 Apr 2013 18:08:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 645F3E05EC; Thu, 4 Apr 2013 18:08:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 76A1DE05A5 for ; Thu, 4 Apr 2013 18:08:38 +0000 (UTC) Received: from pomiocik.lan (77-253-144-190.adsl.inetia.pl [77.253.144.190]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 7375233DC6F; Thu, 4 Apr 2013 18:08:36 +0000 (UTC) Date: Thu, 4 Apr 2013 19:53:38 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: aballier@gentoo.org Subject: Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib Message-ID: <20130404195338.2a92e723@pomiocik.lan> In-Reply-To: <20130404100706.7e89e3ce@portable> References: <20130323172532.1b1100e2@pomiocik.lan> <20130401111951.451ca58f@pomiocik.lan> <20130402125943.4ded3b1f@portable> <20130402134707.01c8e8ab@pomiocik.lan> <20130404100706.7e89e3ce@portable> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/9vOsCHhygpvBmdFK9ZXIoEx"; protocol="application/pgp-signature" X-Archives-Salt: 0b6a9baa-02bc-4571-91fa-56b98180ebd5 X-Archives-Hash: 0ccddef3afe058af2a710f9043193f90 --Sig_/9vOsCHhygpvBmdFK9ZXIoEx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 4 Apr 2013 10:07:06 +0200 Alexis Ballier wrote: > > It will be when there's a safe, public API for it. Right now, it's too > > fragile. >=20 > What exactly is the unsafe part of the API of this function ? Well, the first thing was using $ABI directly, and I sent a patch for that one already. > You could > very well make it functional by replacing MULTILIB_WRAPPED_HEADERS by > arguments to the function and then it'd do what it's supposed to: MULTILIB_WRAPPED_HEADERS will go public, I think. It's kind of nice to have a single way to list them. > wrap > headers from its arguments into a multilib-safe header, move the unsafe > headers to "${ED}"/tmp/multilib-include ; if this function is called, > then multibuild_merge_root "${ED}"/tmp/multilib-include > "${ED}"/usr/include > _must_ be called at the end of src_install. That part is fragile. I'd rather keep both steps encapsulated into two functions. Especially that if we decide to support wrapping headers outside /usr/include, the latter part would have to change. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/9vOsCHhygpvBmdFK9ZXIoEx Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRXb4oXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKfDEQAOsvl1+yGbQyuCBYfZ3Q+ZRb 7OKhXjax1Sz8BpxXR3NOvXo580DhNnJzkOVSBZgvJgBixVc7RGJylRdyCV4wtQ6R KDdYCUMxFK/OW2L00GmwdV6MmJRVLaiK8L3/TSCBGp2HYglJJe7xnFWBHnnQIfxc 4O+EeZksE8O9lQxWNj/vHLpqTuCFuvw41jLkHRp6xhE9EBE3MzC1BRoP3DSHZkzE wYbd8yxeB2RGXSR+/F5Hujaxdq1MflxGLqnWTlQMANNkNPmYTlJoc0CMQyfdQ4TD NY0TtYfXa97x3m6XxXQWgG4Gg+2lLrLkWB0vAZso7/zYaFQWZsFFVwULJ5/veVzo QllvhCihGD2Qt6V/wJ23BBWOsyvpXSgd2XxIf+eDx0Y37tw3VW5xKTN0cg8Mw7EY 9h4HqfOsURxkB2Uod0mfWqiW3MspRXkPu1jhSvvQeqyP6sNLP7Ttpd+Ju0vi+mLa UxmH7y41CX/D2DffbcZrHuaC/qk8slBInFc7fY6ibt47/BBXEKijf5YpZNN8sAJg Rw/AlZBnAfzjkgsyNWDqzNSsVfZsvMVZHrLh5hQKXilk0I+zBAQeCXg0vbeWjxAf af2sCdOxVaUpEr7DRlMocTIz9I9s2A+usTkUfcZtFgopafLn6Ol7YndGd9RuVcR8 17jTGHr3Qy4nRZyn52Oh =8uLN -----END PGP SIGNATURE----- --Sig_/9vOsCHhygpvBmdFK9ZXIoEx--