From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9FC40138010 for ; Thu, 4 Apr 2013 08:07:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8D798E0821; Thu, 4 Apr 2013 08:07:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B0778E0812 for ; Thu, 4 Apr 2013 08:07:13 +0000 (UTC) Received: from portable (AMontpellier-651-1-308-49.w92-133.abo.wanadoo.fr [92.133.67.49]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id ED41133DD3B; Thu, 4 Apr 2013 08:07:11 +0000 (UTC) Date: Thu, 4 Apr 2013 10:07:06 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Cc: mgorny@gentoo.org Subject: Re: [gentoo-dev] [PATCHES] Header wrapping support for multilib Message-ID: <20130404100706.7e89e3ce@portable> In-Reply-To: <20130402134707.01c8e8ab@pomiocik.lan> References: <20130323172532.1b1100e2@pomiocik.lan> <20130401111951.451ca58f@pomiocik.lan> <20130402125943.4ded3b1f@portable> <20130402134707.01c8e8ab@pomiocik.lan> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 270b2bfb-22ce-4e8c-a864-fa67b16645de X-Archives-Hash: a9106bb7b8c09d9009723f1e774b9cff On Tue, 2 Apr 2013 13:47:07 +0200 Micha=C5=82 G=C3=B3rny wrote: [...] > > - Header wrapping really has nothing to do with autotools and I > > strongly believe this should be moved to multilib-build. >=20 > It will be when there's a safe, public API for it. Right now, it's too > fragile. >=20 The problem is that at the moment it prevents non autotools{/,-utils} based packages to do the wrapping. If _autotools-multilib_wrap_headers were in multilib-build, it'd be trivial to add header wrapping support in multilib-minimal. What exactly is the unsafe part of the API of this function ? You could very well make it functional by replacing MULTILIB_WRAPPED_HEADERS by arguments to the function and then it'd do what it's supposed to: wrap headers from its arguments into a multilib-safe header, move the unsafe headers to "${ED}"/tmp/multilib-include ; if this function is called, then multibuild_merge_root "${ED}"/tmp/multilib-include "${ED}"/usr/include _must_ be called at the end of src_install. It's a weird API but after all it's not supposed to be used by everyone ;) Alexis.