From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0A8B1138010 for ; Wed, 3 Apr 2013 09:51:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A0327E0D72; Wed, 3 Apr 2013 09:51:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A69E6E0D69 for ; Wed, 3 Apr 2013 09:51:20 +0000 (UTC) Received: from pomiocik.lan (87-205-60-160.adsl.inetia.pl [87.205.60.160]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 7E5DE33BE5C; Wed, 3 Apr 2013 09:51:17 +0000 (UTC) Date: Wed, 3 Apr 2013 11:52:16 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: tommy@gentoo.org Subject: Re: [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value Message-ID: <20130403115216.46d0b9c8@pomiocik.lan> In-Reply-To: <515BF90F.40107@gentoo.org> References: <20130402234242.5c97d709@pomiocik.lan> <515BF90F.40107@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/_3JhrvwpRX8wm/7yBH2afHI"; protocol="application/pgp-signature" X-Archives-Salt: d82cf3b6-ade6-4f61-9707-a1bcee3cef9c X-Archives-Hash: c11dbdb21054e671a6ca38fdbb368508 --Sig_/_3JhrvwpRX8wm/7yBH2afHI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 03 Apr 2013 11:40:31 +0200 Thomas Sachau wrote: > Micha=C5=82 G=C3=B3rny schrieb: > > Hello, > >=20 > > Currently, the multilib-build eclass uses abi_* constants only for USE > > flags and only ${ABI} is exported to the function. This is bad since it > > basically requires a reverse mapping of ABI->abi_* values, often > > inlined as ${ABI} checks. > >=20 > > The patches which I will send in reply to this thread aim to fix it. > >=20 > > The first patch changes the eclass logic. The abi_* values, with 'abi_' > > prefix stripped, are called MULTILIB_ABI now. They are used to run > > the 'foreach' functions, and now are set in the called functions along > > with ABI. > >=20 > > As a downside, the switch required the MULTILIB_ABI -> ABI mapping to > > occur inside foreach -- as in, another 'for' loop. It shouldn't cause > > any noticeable difference. > >=20 > > Additionally, the 'default' fallback no longer calls > > multilib_toolchain_setup. This should improve compatibility with > > multilib-portage and *maybe* cross-compiling. >=20 > You know, that multilib-portage does use MULTILIB_ABI as USE-expanded > variable? Using exactly the same in the eclass will call for collision > issues. Argv. Could you suggest a new name then? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/_3JhrvwpRX8wm/7yBH2afHI Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRW/vQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKsW4QAJcYuRUoYQpoXyisEqFQRqUI vYLaZuyAALQmILcdedYKYQELfvTzggzi9JOcOpurIJ4nlH+wivWQlUfLC/qupUEt djvfGAZBlObOiq+lH75cQuH0Kfe+/L8zy0sLIyl4Sg6mwcxq2jvhjg9w471LDYj1 207joeQyTVt76I/ORGi91lB7gcm6luMT74vwZg80zWdvP1wZCItrE14aKf6NSV8E SvFS+aGJvzoCZLoxt6UBpdVAtjnnmh8OgA5TCYXH3oFGfV9M82fSufcOap8WTdol Qunuv0Y4rEaewUDvq2q/dPx2rAb2E0dumZVcyHLPoaPEAPRrZQR/cPXIswaoAFMp W6baPH39BlsBa1c1hbPBNR97M/eMSJJnbV8JGxzOnTGPGn7OkU9lFFj+vgduC0pT tXDyFsXNhpfkShaikxYSlMWH9DrFILO/CKL1BlcGrfRCNtP+Xhgr4qZkU4wkaP/3 C4WkcTlO3DsHWHl0bLKOK2/maJMnU8hn6FHWrrHwlOIvrQAbVH8k5S/2SuawRzwB Q1ByR1/SI7heEYRGNkIBTEjcqSFyUpwThpw0MieoMrINbqIyypT6De47h0SBzJFd 4wQt5k/O1rO8GwWX5V20RwQz/686rOHyVUAFr+ssEJuRi7pspKhggUjwt5kerw+Y UbpOzGr/66R6zTg5ShcX =5cgz -----END PGP SIGNATURE----- --Sig_/_3JhrvwpRX8wm/7yBH2afHI--