From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9CC64138010 for ; Tue, 2 Apr 2013 21:41:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BE385E0E13; Tue, 2 Apr 2013 21:41:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CE59FE0DF6 for ; Tue, 2 Apr 2013 21:41:44 +0000 (UTC) Received: from pomiocik.lan (87-205-60-160.adsl.inetia.pl [87.205.60.160]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 30EB333DC34; Tue, 2 Apr 2013 21:41:42 +0000 (UTC) Date: Tue, 2 Apr 2013 23:42:42 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Gentoo Developer Mailing List Subject: [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value Message-ID: <20130402234242.5c97d709@pomiocik.lan> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/yHsgD.3wCHSA4H=iEHB0ENT"; protocol="application/pgp-signature" X-Archives-Salt: 36b1408f-9c70-467d-afe1-d1a276abb571 X-Archives-Hash: 4641babe5348b081ce2d248273f58e80 --Sig_/yHsgD.3wCHSA4H=iEHB0ENT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, Currently, the multilib-build eclass uses abi_* constants only for USE flags and only ${ABI} is exported to the function. This is bad since it basically requires a reverse mapping of ABI->abi_* values, often inlined as ${ABI} checks. The patches which I will send in reply to this thread aim to fix it. The first patch changes the eclass logic. The abi_* values, with 'abi_' prefix stripped, are called MULTILIB_ABI now. They are used to run the 'foreach' functions, and now are set in the called functions along with ABI. As a downside, the switch required the MULTILIB_ABI -> ABI mapping to occur inside foreach -- as in, another 'for' loop. It shouldn't cause any noticeable difference. Additionally, the 'default' fallback no longer calls multilib_toolchain_setup. This should improve compatibility with multilib-portage and *maybe* cross-compiling. The second patch uses new ${MULTILIB_ABI} variable in header wrapping function. In other words, it removes the ABI -> MULTILIB_ABI reverse mapping which becomes unnecessary. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/yHsgD.3wCHSA4H=iEHB0ENT Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRW1DSXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKbNkQANaRro/NmW6l/dZ+q7P3FbZJ nIlSjRz7z7sBJBTN2r+qhflM0xAYNAaYU1hnLcOgtCdyfeKKuXgjJAsxsV9JLxFL 47KuddrURANR4nf6D7e7Ns2I6Qp9ux9KjqyEul1vT0KsbfJJcz84hpNIR3ycyyO1 +BV36UPiJ2AULQqaeToV8IiIy5FX4qge3fcXqrr2PY8VF/udRvOTb91u8O4KGFEU uLcMdvif39Wc0XxozTS4KpZAZ7mGqfCLkVQyC7k5XMYdExw+Cd5JxuSwKeT92U39 ROfi/IbKrEcCeqm5twctd+NgvvLZz0MZKC6h5lT9/dCbmbq80ygV4hNJlwXQaU/P 6ILWnwSv/KIv1b9tvKRmi2lv4uU9BhxCPhzY02JqY8bc72045rGFR+h4lrwBi0I6 wPcWqOB+TaOxR1mTNQlRuPNZj16EHBmXkQQiB89NguX3GifPaKesmKEeglz26K1j 2W9HX56fHXGE9/b41dw2+78DcCRMOF8STQB4md5kJFVuYppJunajizppXlyrU2Y9 hzh9gSrDJfcYz/UDBdOLAKyGxrB32nJzPuCgxStuGh1qrqHVnNN9OFRvTR38mHwU Y0xsOmx9MIMaLYbnAtfNJPgHLBCcETYrT5q00cqrTZkY7poJl40mGeFlZVG2LKvO L3C/W3kkq6C7nuIEzK2i =kQoZ -----END PGP SIGNATURE----- --Sig_/yHsgD.3wCHSA4H=iEHB0ENT--