From: "Michał Górny" <mgorny@gentoo.org>
To: Gentoo Developer Mailing List <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value
Date: Tue, 2 Apr 2013 23:42:42 +0200 [thread overview]
Message-ID: <20130402234242.5c97d709@pomiocik.lan> (raw)
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Hello,
Currently, the multilib-build eclass uses abi_* constants only for USE
flags and only ${ABI} is exported to the function. This is bad since it
basically requires a reverse mapping of ABI->abi_* values, often
inlined as ${ABI} checks.
The patches which I will send in reply to this thread aim to fix it.
The first patch changes the eclass logic. The abi_* values, with 'abi_'
prefix stripped, are called MULTILIB_ABI now. They are used to run
the 'foreach' functions, and now are set in the called functions along
with ABI.
As a downside, the switch required the MULTILIB_ABI -> ABI mapping to
occur inside foreach -- as in, another 'for' loop. It shouldn't cause
any noticeable difference.
Additionally, the 'default' fallback no longer calls
multilib_toolchain_setup. This should improve compatibility with
multilib-portage and *maybe* cross-compiling.
The second patch uses new ${MULTILIB_ABI} variable in header wrapping
function. In other words, it removes the ABI -> MULTILIB_ABI reverse
mapping which becomes unnecessary.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]
next reply other threads:[~2013-04-02 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 21:42 Michał Górny [this message]
2013-04-02 21:43 ` [gentoo-dev] [PATCH 1/2] multilib-build: set MULTILIB_ABI as the 'global' ABI value Michał Górny
2013-04-02 21:43 ` [gentoo-dev] [PATCH 2/2] Use MULTILIB_ABI in header wrapping code Michał Górny
2013-04-03 9:40 ` [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value Thomas Sachau
2013-04-03 9:40 ` Ciaran McCreesh
2013-04-03 9:52 ` Michał Górny
2013-04-05 3:53 ` Michał Górny
2013-04-05 20:56 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402234242.5c97d709@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox