public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ciaran.mccreesh@googlemail.com
Subject: Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.
Date: Sun, 10 Mar 2013 14:19:59 +0100	[thread overview]
Message-ID: <20130310141959.6217437d@pomiocik.lan> (raw)
In-Reply-To: <20130310121825.054383fb@googlemail.com>

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Sun, 10 Mar 2013 12:18:25 +0000
Ciaran McCreesh <ciaran.mccreesh@googlemail.com> wrote:

> On Sun, 10 Mar 2013 13:16:46 +0100
> Ulrich Mueller <ulm@gentoo.org> wrote:
> > >>>>> On Sun, 10 Mar 2013, Ulrich Mueller wrote:
> > 
> > >>>>> On Sun, 10 Mar 2013, Michał Górny wrote:
> > >> +DEPEND=">=app-shells/bash-4.2"
> > >> +
> > 
> > > Why is this needed?
> > 
> > Seems it's because of this:
> > 
> > >> +	declare -g -A _MULTIBUILD_EXPORTED_PHASES || die
> > >> +	local p
> > >> +	for p; do
> > >> +		_MULTIBUILD_EXPORTED_PHASES[${p}]=${ECLASS}_${p}
> > >> +	done
> > 
> > Associative arrays are not supported in bash 3.2, so they must not be
> > used in EAPIs 0 to 5.
> 
> A dependency upon a newer bash doesn't guarantee that the package
> mangler will use that bash.

Yep. That's why the non-quoted fragment has a safety check and dies if
it doesn't.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

  reply	other threads:[~2013-03-10 13:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10 10:16 [gentoo-dev] [PATCHES] multibuild.eclass: custom phase function helpers Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions Michał Górny
2013-03-10 11:36   ` Ulrich Mueller
2013-03-10 12:16     ` Ulrich Mueller
2013-03-10 12:18       ` Ciaran McCreesh
2013-03-10 13:19         ` Michał Górny [this message]
2013-03-10 13:44           ` Ulrich Mueller
2013-03-10 13:48             ` Michał Górny
2013-03-10 15:26               ` Ciaran McCreesh
2013-03-10 15:46                 ` Michał Górny
2013-03-10 15:46                   ` Ciaran McCreesh
2013-03-10 15:50       ` [gentoo-dev] [PATCH] " Michał Górny
2013-03-10 18:37         ` Alec Warner
2013-03-10 10:18 ` [gentoo-dev] [PATCH 2/7] distutils-r1: use multibuild phase helpers Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 3/7] multilib-minimal: split out mkdir to unify sub-functions Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 4/7] multilib-minimal: reuse run_in_build_dir Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 5/7] multilib-minimal: reuse multibuild phase function handlers Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 6/7] multilib-minimal: run multilib_src_configure in parallel Michał Górny
2013-03-10 10:18 ` [gentoo-dev] [PATCH 7/7] autotools-multilib: reuse phase functions from multilib-minimal Michał Górny
2013-03-17 13:35 ` [gentoo-dev] [PATCHES] multibuild.eclass: custom phase function helpers Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310141959.6217437d@pomiocik.lan \
    --to=mgorny@gentoo.org \
    --cc=ciaran.mccreesh@googlemail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox