From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8C83B198005 for ; Sun, 3 Mar 2013 22:59:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3D76FE064E; Sun, 3 Mar 2013 22:59:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3B2BAE05EC for ; Sun, 3 Mar 2013 22:59:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7230733DDF5 for ; Sun, 3 Mar 2013 22:59:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -1.513 X-Spam-Level: X-Spam-Status: No, score=-1.513 tagged_above=-999 required=5.5 tests=[AWL=-0.807, RP_MATCHES_RCVD=-0.704, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=no Received: from smtp.gentoo.org ([IPv6:::ffff:127.0.0.1]) by localhost (smtp.gentoo.org [IPv6:::ffff:127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hEUVjs8FB3JT for ; Sun, 3 Mar 2013 22:59:26 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 5087E33DDB4 for ; Sun, 3 Mar 2013 22:59:24 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UCHsc-0007dT-Cg for gentoo-dev@gentoo.org; Sun, 03 Mar 2013 23:59:42 +0100 Received: from 71-17-69-121.yktn.hsdb.sasknet.sk.ca ([71.17.69.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Mar 2013 23:59:42 +0100 Received: from dirtyepic by 71-17-69-121.yktn.hsdb.sasknet.sk.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Mar 2013 23:59:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-drivers/nvidia-drivers: nvidia-drivers-313.18.ebuild ChangeLog Date: Sun, 3 Mar 2013 17:09:45 -0600 Organization: Gentoo Message-ID: <20130303170945.6021e2c9@caribou.gateway.2wire.net> References: <20130302160257.B3FCB2171D@flycatcher.gentoo.org> <5132F549.1020504@gentoo.org> <51336170.1030802@gentoo.org> <20130303112439.019eb225@caribou.gateway.2wire.net> <5133C928.9050506@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/i2UiQDGYiv+9gu1hfjPt5ky"; protocol="application/pgp-signature" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 71-17-69-121.yktn.hsdb.sasknet.sk.ca X-Newsreader: Claws Mail 3.9.0 (GTK+ 2.24.16; x86_64-pc-linux-gnu) X-Archives-Salt: 55b16bf4-d3a1-4e5e-a99d-4f8203294eb4 X-Archives-Hash: 1ac89f6cae136ba20a69697aa79069b9 --Sig_/i2UiQDGYiv+9gu1hfjPt5ky Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 03 Mar 2013 23:05:28 +0100 hasufell wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On 03/03/2013 06:24 PM, Ryan Hill wrote: > > On Sun, 03 Mar 2013 15:42:56 +0100 hasufell > > wrote: > >=20 > >> What do we have useflags for in gentoo? > >=20 > > Not for conditional patching, that's for sure. > >=20 >=20 > That simply diverges from reality. >=20 > # qgrep epatch | grep 'use\ ' | wc -l > 476 >=20 > Since conditional seds are practically the same... >=20 > # qgrep ' sed ' | grep 'use\ ' | wc -l > 447 >=20 > And those are just lazy greps not catching if else foo syntax. Sometimes it's unavoidable. Sometimes people don't think before they do something. If the patch makes a fundamental change in the package that can= 't be controlled another way (say --configure flags or defines) then, yes, you= may have to use conditional patching. I'm thinking of something like infinalit= y or x32 support. In both those cases we're adding a feature, not making a bug fix. That's an important distinction. USE flags exist to give the user a choice between A and B. If choice A is "package doesn't build" then there's really no choice at all. You've just added a new way for a package to fail.= We already have plenty of those. Please don't add more. --=20 gcc-porting toolchain, wxwidgets learn a language baby, it's that kind of pl= ace @ gentoo.org where low card is hunger and high card is ta= ste --Sig_/i2UiQDGYiv+9gu1hfjPt5ky Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBCgAGBQJRM9g/AAoJEO04vUmVeoRjrJ8IALlZYRI2oWS47EW00PyZG0as IuxbRSkcukEsLAnhQKVUftRncFxtMehPFKFJrivN0GEsDDcvv96YO7I0+xpmSA7L moA6M+0/8Xenrt9Mx7ec9EiqASPYgamzKXuWWOc4OJNnmfh0z7CKcOyjUGi8m5Wc 1IUHRTh0D/VU7j6KV4rcbECaHRm4ZKIwJQ2ha8AIjsbKxZwiVGnY3MeAw18As6LH UiigbpRZO8nbD+jddX9qyD0nG1d2AJ0dJYC34JVtGmV5b1JaZyhRhZcdBNKz0f7o 8bnM9JWgrYNrzf3YAVsws02pU5Njtwlz/DrABlkLWlNL2M53VzLvW2LN+y3sLOM= =wxbv -----END PGP SIGNATURE----- --Sig_/i2UiQDGYiv+9gu1hfjPt5ky--