Re: [gentoo-dev] [PATCH 1/4] multibuild: print only 'public' part of command-line.

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

On Sat, 2 Mar 2013 14:52:25 -0800
Alec Warner <antarus@gentoo.org> wrote:

> On Sat, Mar 2, 2013 at 1:42 PM, Michał Górny <mgorny@gentoo.org> wrote:
> > Shift the unnecessary 'private' commands from the printed commands when
> > executing.
> >
> > That is:
> >
> >         python_parallel_foreach_impl foo
> >
> > will print:
> >
> >         * pythonX.Y: foo
> >
> > rather than:
> >
> >         * pythonX.Y: _multibuild_parallel _python_multibuild_wrapper ...
> > ---
> >  gx86/eclass/multibuild.eclass | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/gx86/eclass/multibuild.eclass b/gx86/eclass/multibuild.eclass
> > index 1c9058a..1cc33a9 100644
> > --- a/gx86/eclass/multibuild.eclass
> > +++ b/gx86/eclass/multibuild.eclass
> > @@ -118,12 +118,23 @@ multibuild_foreach_variant() {
> >                 # redirect_alloc_fd accepts files only. so we need to open
> >                 # a random file and then reuse the fd for logger process.
> >                 redirect_alloc_fd log_fd /dev/null
> > +
> > +               _multibuild_run() {
> > +                       # find the first non-private command
> > +                       local i=1
> > +                       while [[ ${!i} == _* ]]; do
> > +                               (( i += 1 ))
> > +                       done
> > +
> > +                       einfo "${v}: running ${@:${i}}"
> 
> So this is an einfo with an assignment side-effect? Can we perhaps
> make the assignment explicit?

Assignment side-effect? I don't understand.

Maybe I'm missing something but by design it was supposed to print ${@}
starting from ${i}-th item.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]